Project

General

Profile

Actions

Patch #25320

closed

Remove initial indentation of blockquotes for better readability

Added by Jan from Planio www.plan.io about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

90%

Estimated time:

Description

Currently, quoted text in Redmine is rendered with the blockquote element which is styled to be a grey vertical bar.

On the second and onward levels, the indentation of quotes equals the width of the bar plus some padding to the right.

Only on the first level, there is some additional margin to the left indenting the entire quote block even more. I find quotes to be more readable and more visually appealing if this margin was removed. Hence this patch.

How it looks now:

How it will look with the patch:

The patch will also apply this to HTML in notification emails.


Files

blockquotes_after.png (104 KB) blockquotes_after.png Jan from Planio www.plan.io, 2017-03-14 07:07
blockquotes_before.png (104 KB) blockquotes_before.png Jan from Planio www.plan.io, 2017-03-14 07:07
0001-Remove-initial-indentation-for-block-quotes.patch (2.45 KB) 0001-Remove-initial-indentation-for-block-quotes.patch Jan from Planio www.plan.io, 2017-03-14 09:20
Actions #1

Updated by Go MAEDA about 7 years ago

I think that source:trunk/app/views/layouts/mailer.html.erb@16087#L28 should be updated if the proposed patch is merged.

Actions #2

Updated by Marius BÄ‚LTEANU about 7 years ago

The proposed change looks good to me.

Actions #3

Updated by Go MAEDA about 7 years ago

Go MAEDA wrote:

I think that source:trunk/app/views/layouts/mailer.html.erb@16087#L28 should be updated if the proposed patch is merged.

Sorry, the patch also updates mailer.html.erb. I missed it.

Actions #4

Updated by Jan from Planio www.plan.io about 7 years ago

Thanks for your feedback, Go and Marius.

Sadly, I overlooked RTL support. Here's an updated patch including the proposed change for RTL writing systems, e.g. Arabic.

Actions #5

Updated by Jan from Planio www.plan.io about 7 years ago

  • File deleted (0001-Remove-initial-indentation-for-block-quotes.patch)
Actions #6

Updated by Jean-Philippe Lang about 7 years ago

Sounds good to me.

Actions #7

Updated by Go MAEDA about 7 years ago

  • Status changed from Needs feedback to New
  • Target version changed from Candidate for next minor release to 3.4.0

Jean-Philippe Lang wrote:

Sounds good to me.

Setting target version to 3.4.0.

Actions #8

Updated by Jean-Philippe Lang about 7 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

Actions #9

Updated by JP Vossen over 6 years ago

I disagree on this one. I prefer the indentation, which I think makes the quote stand out more. Any chance of making this optional?

Actions #10

Updated by Mischa The Evil over 6 years ago

JP Vossen wrote:

[...] Any chance of making this optional?

I don't think so. However, as this change consists of (mostly) theme-able CSS, it should be pretty easy to modify your theme to re-add the indentation.

Actions #11

Updated by budo kaiman over 6 years ago

I'll +1 this, I think the change looks much better.

Actions

Also available in: Atom PDF