Patch #25320
closed
Remove initial indentation of blockquotes for better readability
Added by Jan from Planio www.plan.io over 7 years ago.
Updated over 7 years ago.
Description
Currently, quoted text in Redmine is rendered with the blockquote
element which is styled to be a grey vertical bar.
On the second and onward levels, the indentation of quotes equals the width of the bar plus some padding to the right.
Only on the first level, there is some additional margin to the left indenting the entire quote block even more. I find quotes to be more readable and more visually appealing if this margin was removed. Hence this patch.
How it looks now:
How it will look with the patch:
The patch will also apply this to HTML in notification emails.
Files
The proposed change looks good to me.
Thanks for your feedback, Go and Marius.
Sadly, I overlooked RTL support. Here's an updated patch including the proposed change for RTL writing systems, e.g. Arabic.
- File deleted (
0001-Remove-initial-indentation-for-block-quotes.patch)
- Status changed from Needs feedback to New
- Target version changed from Candidate for next minor release to 3.4.0
Jean-Philippe Lang wrote:
Sounds good to me.
Setting target version to 3.4.0.
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
I disagree on this one. I prefer the indentation, which I think makes the quote stand out more. Any chance of making this optional?
JP Vossen wrote:
[...] Any chance of making this optional?
I don't think so. However, as this change consists of (mostly) theme-able CSS, it should be pretty easy to modify your theme to re-add the indentation.
I'll +1 this, I think the change looks much better.
Also available in: Atom
PDF