Defect #25794
closedMass-deleted attachments are not represented correctly in email notifications
0%
Description
When deleting more than one attachment through the mass-delete attachments feature on the issue edit pane, only the first deleted attachment is in email notifications that are sent out for this event. The journal details are also created for the remaining deleted attachments, but they are not part of the email notifications.
This is due to source:/trunk/app/models/issue.rb@16545#L1742 calling current_journal.save
after each deleted attachment. This causes the email notification for the journal to be sent on the first time it is called, still missing the other attachment deletions.
I'm not quite sure of the best way to solve this as removing the currrent_journal.save
messes with other things, for example removing a single attachment via clicking the trash bin next to it.
Related issues
Updated by Felix Schäfer over 7 years ago
I just noticed I linked to the wrong tag: this only affects trunk currently. Sorry for the confusion.
Updated by Mischa The Evil over 7 years ago
- Related to Feature #13072: Delete multiple attachments with one action added
Updated by Mischa The Evil over 7 years ago
- Description updated (diff)
- Affected version deleted (
3.3.3)
Good catch. I've adjusted the issue properties accordingly.
Updated by Mischa The Evil over 7 years ago
- Description updated (diff)
Corrected the source link to current trunk. Sorry for the fuzz...
Updated by Jean-Philippe Lang over 7 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Fixed in r16573 by sending the notification after commit.
Updated by Go MAEDA over 7 years ago
- Target version set to 3.4.0
Setting target version to put this issue in changelog.
Updated by Jean-Philippe Lang over 7 years ago
- Target version deleted (
3.4.0)
This defect is related to a feature added in 3.4.0, it should not appear in the changelog.
Updated by Go MAEDA over 7 years ago
- Related to Feature #25538: Drop support for Ruby 2.2.1 and ealier, 2.2.2+ is now required added
Updated by Toshi MARUYAMA over 7 years ago
- Related to Defect #26627: Editing issues no longer sends notifications to previous assignee added