Project

General

Profile

Actions

Defect #25794

closed

Mass-deleted attachments are not represented correctly in email notifications

Added by Felix Schäfer over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Urgent
Category:
Issues
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

When deleting more than one attachment through the mass-delete attachments feature on the issue edit pane, only the first deleted attachment is in email notifications that are sent out for this event. The journal details are also created for the remaining deleted attachments, but they are not part of the email notifications.

This is due to source:/trunk/app/models/issue.rb@16545#L1742 calling current_journal.save after each deleted attachment. This causes the email notification for the journal to be sent on the first time it is called, still missing the other attachment deletions.

I'm not quite sure of the best way to solve this as removing the currrent_journal.save messes with other things, for example removing a single attachment via clicking the trash bin next to it.


Related issues

Related to Redmine - Feature #13072: Delete multiple attachments with one actionClosedJean-Philippe Lang

Actions
Related to Redmine - Feature #25538: Drop support for Ruby 2.2.1 and ealier, 2.2.2+ is now requiredClosedJean-Philippe Lang

Actions
Related to Redmine - Defect #26627: Editing issues no longer sends notifications to previous assigneeClosedJean-Philippe Lang

Actions
Actions

Also available in: Atom PDF