Redmine

I think that the improvement is fairly useful but unfortunately the patch cannot be applied to the current trunk (r16559) cleanly. Could you tell me how can I apply them?

$ patch -p1 < 0001-Move-download-link-to-contextual-area.patch
patching file app/views/layouts/_file.html.erb
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file app/views/layouts/_file.html.erb.rej
patching file app/views/repositories/_link_to_functions.html.erb
Reversed (or previously applied) patch detected!  Assume -R? [n]

Go MAEDA wrote:

I think that the improvement is fairly useful but unfortunately the patch cannot be applied to the current trunk (r16559) cleanly. Could you tell me how can I apply them?

I am sorry, I failed to mention that #25999 and therefore #25988 are required for this patch to apply cleanly.

My two cents based on the screenshots:

Jan from Planio www.plan.io wrote:

[...] this small patch series proposes to move the file download link on previews to a more common place – the contextual area.

I'm not sure about this change. The current contextual area does not seem to be the best place for such a link (and an eventual 'raw' link as proposed in #25357). I kinda like the current (and #25999 's) link position (I'm aware of the fact this is really a matter of taste, which is a difficult thing design-wise...).

Jan from Planio www.plan.io wrote:

It also introduces another link wihin the "No preview available" message to make it easier for users to download a file instead of previewing it.

Nice one.