Project

General

Profile

Actions

Feature #26071

closed

Generate markup for uploaded image dropped into wiki-edit textarea

Added by Felix Gliesche over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

As it is already possible to upload files by using drag n drop, it'd be a great UI improvement to immediately generate the markup for an image when dragged into a textarea. We have seen this feature at github and think it would be a great UI improvement to redmine. For example, if you drag an image into an issue's description field you'll get !image.png! (if formatting is set to textile) or ![](image.jpg) (if formatting is set to markdown) at the current cursor position.

I am attaching a patch that introduces this feature into redmine. Allowed are all image file types that are listed in redmine's mime_types. The behavior remains the same for all other file types / non-image file types.


Files


Related issues

Related to Redmine - Defect #10189: Inline image does not work with spaces in file nameNew

Actions
Related to Redmine - Feature #17438: Support embedding images/files in issue descriptionClosed

Actions
Related to Redmine - Patch #26682: URL-escape the ! character in generated markup for dropped uploadsClosedJean-Philippe Lang

Actions
Related to Redmine - Feature #7979: Automatically show attached images in-lineClosed2011-03-24

Actions
Related to Redmine - Patch #31169: Wiki syntax help for document image pasting and drag/drop embeddingClosedGo MAEDA

Actions
Has duplicate Redmine - Feature #4491: Direct Image Upload in ForumClosed2009-12-27

Actions
Actions #1

Updated by Marius BÄ‚LTEANU over 6 years ago

Very nice improvement!

Actions #2

Updated by Go MAEDA over 6 years ago

  • Target version set to 3.4.0

I have been wanting this feature for a long time. It is a great improvement.
I tried out the patch and works very fine. I think there is no reason not to deliver this feature in upcoming 3.4.0.

Actions #4

Updated by Vipama Lucyu over 6 years ago

Worked for me at <<link removed>>

Edited by Mischa The Evil.

Actions #5

Updated by Jan from Planio www.plan.io over 6 years ago

  • File deleted (0001-Generate-markup-for-uploaded-image-dropped-into-wiki.patch)
Actions #6

Updated by Fernando Hartmann over 6 years ago

Great, could this patch support file names with spaces too? #10189

Actions #7

Updated by Felix Gliesche over 6 years ago

Fernando Hartmann wrote:

Great, could this patch support file names with spaces too? #10189

Yes! This patch works for filename with spaces, because it encodes the filename accordingly before generating the markup.

Actions #8

Updated by Mischa The Evil over 6 years ago

Nice improvement indeed. LGTM.

Actions #9

Updated by Jean-Philippe Lang over 6 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Nice, thanks!

Actions #10

Updated by Toshi MARUYAMA over 6 years ago

  • Related to Defect #10189: Inline image does not work with spaces in file name added
Actions #11

Updated by Go MAEDA over 6 years ago

  • Related to Feature #17438: Support embedding images/files in issue description added
Actions #12

Updated by Go MAEDA over 6 years ago

  • Related to Patch #26682: URL-escape the ! character in generated markup for dropped uploads added
Actions #13

Updated by Go MAEDA over 5 years ago

  • Related to Feature #7979: Automatically show attached images in-line added
Actions #14

Updated by Go MAEDA about 5 years ago

  • Has duplicate Feature #4491: Direct Image Upload in Forum added
Actions #15

Updated by Go MAEDA almost 5 years ago

  • Related to Patch #31169: Wiki syntax help for document image pasting and drag/drop embedding added
Actions

Also available in: Atom PDF