Feature #26620
closed
Change the text of the submit button on search page from button_submit to label_search
Added by Dmitry Lisichkin almost 7 years ago. Updated over 5 years ago.
0%
Description
:button_search is more intuitive then :button_submit
Files
| fix_button_text.patch (542 Bytes) fix_button_text.patch | Dmitry Lisichkin, 2017-08-03 17:33 | ||
| button_search.png (102 KB) button_search.png | Marius BĂLTEANU, 2018-12-02 16:21 |
Updated by Toshi MARUYAMA almost 7 years ago
- Status changed from New to Needs feedback
Where is "button_search" defined?
"button_submit" is defined at source:trunk/config/locales/en.yml@16905#L1030 .
Updated by Dmitry Lisichkin almost 7 years ago
Sorry, I didn't notice that button_search is not defined in core.
I just try to remove maximum of patches from our plugins=).
Problem that button_submit have translations that not always appropriate in some contexts.
In russian it translated as "Принять" and it looks very strange on search page but looks normal on most of other forms.
So I think was good if button_search would be in core too.
Updated by Toshi MARUYAMA over 6 years ago
Dmitry Lisichkin wrote:
So I think was good if button_search would be in core too.
Do you think :button_search should be used in only app/views/search/index.html.erb?
In other word, other :button_submit should be kept?
Updated by Toshi MARUYAMA over 6 years ago
- Category changed from UI to Translations
Updated by Toshi MARUYAMA over 6 years ago
What do you think :button_search should be in English en.yml?
Updated by Dmitry Lisichkin over 6 years ago
Sorry for long response.
Yes I think button_search should be in en.yaml even with only one usage in view.
IMHO "search"-button on search form is much better then "submit"-button.
Updated by Go MAEDA over 5 years ago
- Tracker changed from Defect to Feature
- Subject changed from Wrong text of submit button on search page to Change the text of the submit button on search page from button_submit to label_search
- Category changed from Translations to Search engine
- Status changed from Needs feedback to Closed
- Assignee set to Go MAEDA
- Target version changed from 4.1.0 to 4.0.0
- Resolution set to Fixed
Committed. Thank you for improving Redmine.
Updated by Marius BĂLTEANU over 5 years ago
- File button_search.png button_search.png added
- Status changed from Closed to Reopened
For me, this change generates "translation missing: en.button_search". Please see the below screenshot.
In the existing locales, we have only "label_search". We can use this one (my option) or we need to add the "button_search" to locales.
diff --git a/app/views/search/index.html.erb b/app/views/search/index.html.erb
index 1e80d57..682c11a 100644
--- a/app/views/search/index.html.erb
+++ b/app/views/search/index.html.erb
@@ -32,7 +32,7 @@
<%= hidden_field_tag 'options', '', :id => 'show-options' %>
</div>
-<p><%= submit_tag l(:button_submit) %></p>
+<p><%= submit_tag l(:button_search) %></p>
<% end %>
<% if @results %>
Updated by Go MAEDA over 5 years ago
- Status changed from Reopened to Closed
Marius BALTEANU wrote:
For me, this change generates "translation missing: en.button_search". Please see the below screenshot.
In the existing locales, we have only "label_search". We can use this one (my option) or we need to add the "button_search" to locales.
Fixed in r17684. Thanks.
I changed button_search to label_search before committing as I wrote in the commit message, but probably I mistakenly reverted the local change and applied original patch again.