Patch #26674
closed
Add CSS classes to column headers of issues and timelogs list
Added by Dmitry Lisichkin over 6 years ago. Updated over 6 years ago.
Description
For now there no any chances to style table headers for several columns becouse there no any css classes (it just <th> with column caption)
In patch I offer to add two classes: query-column-header and query-column-header-#{column.name}
Files
| additional_css.patch (733 Bytes) additional_css.patch | Dmitry Lisichkin, 2017-08-14 11:38 | ||
| additional_css_for_query_column_headers.patch (3.39 KB) additional_css_for_query_column_headers.patch | Marius BĂLTEANU, 2017-12-18 23:45 |
Updated by Go MAEDA over 6 years ago
- Status changed from New to Needs feedback
- Target version set to Candidate for next major release
I agree that adding classes is a nice improvement for theme developers. But I think that class names such as "query-column-header query-column-header-issue" is long and "query-column-header issue" is enough.
What do you think?
Updated by Dmitry Lisichkin over 6 years ago
Go MAEDA wrote:
I agree that adding classes is a nice improvement for theme developers. But I think that class names such as "query-column-header query-column-header-issue" is long and "query-column-header issue" is enough.
What do you think?
Class name contained only column name is not enough to specify context. It may be used in another parts of application and its style will be attached to query-column-header too. For example: if we have column with name 'highlight' then column header will be with background (.highlight { background-color: #FCFD8D;} from application.css).
Updated by Marius BĂLTEANU over 6 years ago
- File additional_css_for_query_column_headers.patch additional_css_for_query_column_headers.patch added
I think we should use the existing `css_classes` method to generate also the classes for query column headers. In this way, both type of cells (th and td) will have the same classes and we can easily target them from CSS. Attach is a patch that implements this and adds multiple assertions.
Regarding the proposed classes, the length is not a problem from my point of view, but we should be consistent with the existing implementations and if we want to change the class name because is not enough to specify the context, the change should apply also for tds.
Updated by Dmitry Lisichkin over 6 years ago
Marius BALTEANU wrote:
I think we should use the existing `css_classes` method to generate also the classes for query column headers
I agree. I prepare new issue with modifications of css_classes but in redmine css we have problem with specify everywhere and we need to fully rewrite application.css. All that fixes will broke all existed redmine themes, so I think that it need to be fixed it in a complex way and only for next major version.
Updated by Marius BĂLTEANU over 6 years ago
- Status changed from Needs feedback to New
Dmitry Lisichkin wrote:
I agree. I prepare new issue with modifications of
css_classesbut in redmine css we have problem with specify everywhere and we need to fully rewriteapplication.css. All that fixes will broke all existed redmine themes, so I think that it need to be fixed it in a complex way and only for next major version.
Totally agree. Until then, this issue can be implemented.
Updated by Toshi MARUYAMA
Updated by Go MAEDA over 6 years ago
Toshi MARUYAMA wrote:
Can we set target 4.0 or 4.1?
I am in favor of #26674#note-3. The patch is simple and consistent with existing classes. I think we can merge it to the trunk.
Updated by Marius BĂLTEANU over 6 years ago
Go MAEDA wrote:
Toshi MARUYAMA wrote:
Can we set target 4.0 or 4.1?
I am in favor of #26674#note-3. The patch is simple and consistent with existing classes. I think we can merge it to the trunk.
Totally agree.
Updated by Go MAEDA over 6 years ago
- Target version changed from Candidate for next major release to 4.1.0
Setting target version to 4.1.0.
Updated by Go MAEDA over 6 years ago
- Subject changed from Additional css for query column headers to Add CSS classes to column headers of issues and timelogs list
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version changed from 4.1.0 to 4.0.0
Committed. Thank you for you all's contribution.