Project

General

Profile

Actions
Copy link

Patch #26682

closed

URL-escape the ! character in generated markup for dropped uploads

Added by Holger Just over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Text formatting
Target version:
3.4.3
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In #26071, we introduced the ability to just drag an image into a textbox and have Redmine generate the correct image markup for the uploaded file for easy inclusion.

Unfortunately, the ! character in the filename is not escaped here. Thus, when using Textile as the markup language and if the filename of the dropped file contains a ! character, the resulting markup will be invalid and the image will not be correctly referenced in the generated HTML.

The attached patch fixes this by explicitly percent-escaping the exclamation mark. While this step is not strictly required for markdown, it doesn't hurt there since the escaped version is strictly equivalent to the unescaped one for URLs.

Files

Download all files
0001-URL-escape-the-character-in-generated-markup-for-dro.patch (1.05 KB) 0001-URL-escape-the-character-in-generated-markup-for-dro.patch Holger Just, 2017-08-14 15:24
26682-before@2x.png (15 KB) 26682-before@2x.png Go MAEDA, 2017-08-15 04:31
26682-after@2x.png (15.4 KB) 26682-after@2x.png Go MAEDA, 2017-08-15 04:31
parentheses@2x.png (10.7 KB) parentheses@2x.png Go MAEDA, 2017-08-15 04:53
0001-URL-escape-additional-characters-with-special-meanin.patch (1.16 KB) 0001-URL-escape-additional-characters-with-special-meanin.patch Holger Just, 2017-08-15 12:11

Related issues

Related to Redmine - Feature #26071: Generate markup for uploaded image dropped into wiki-edit textareaClosedJean-Philippe Lang

Actions
Actions
Copy link

Also available in: Atom PDF