Patch #27090: Show the number of attachments on wiki pages - Redmine

Custom queries

Documentation issues
Open defects
Open features
Patch queue
Plugin issues
Translation patches

Actions

Copy link

Patch #27090

closed

Show the number of attachments on wiki pages

Added by Tomomi Yuzuriha about 7 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Wiki

Target version:

3.4.6

Start date:

Due date:

% Done:

Estimated time:

Description

I noticed the problem that users cannot know whether there are any attachments unless users expand the "File" section by clicking it.

To resolve the problem, I suggest showing attachments count on "Files” section.
Please see the screenshots below for the details.

before
¶

after
¶

Patch: show_attachments_count_of_wiki_page_trunk_r16963.patch
(Compatible the latest trunk r16963.)

Files

Download all files

before.png (50.6 KB) before.png		Tomomi Yuzuriha, 2017-09-28 04:20
after.png (49.6 KB) after.png		Tomomi Yuzuriha, 2017-09-28 04:20
show_attachments_count_of_wiki_page_trunk_r16963.patch (615 Bytes) show_attachments_count_of_wiki_page_trunk_r16963.patch		Tomomi Yuzuriha, 2017-09-28 04:38
show_attachments_count_of_wiki_page-v2.diff (641 Bytes) show_attachments_count_of_wiki_page-v2.diff	Replaced "count" method with "length" method.	Go MAEDA, 2018-01-14 11:07

Related issues

Related to Redmine - Feature #27085: Display a counter beside each tab

New

Actions

Related to Redmine - Feature #12183: Hide attachments by default on wiki pages

Closed

Jean-Philippe Lang

Actions

Has duplicate Redmine - Feature #28893: Show number of attached files in Wiki Files-Link

Closed

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Mischa The Evil about 7 years ago

Target version set to Unplanned backlogs

Nice one, although it can slow down wiki page rendering if a page contains lots of attachments.

Actions

Copy link

Updated by Toshi MARUYAMA about 7 years ago

Related to Feature #27085: Display a counter beside each tab added

Actions

Copy link

Updated by arturo flores about 7 years ago

Alternatively, is there a way of having the files section by expanded by default?

Actions

Copy link

Updated by Go MAEDA almost 7 years ago

File show_attachments_count_of_wiki_page-v2.diff show_attachments_count_of_wiki_page-v2.diff added

Mischa The Evil wrote:

Nice one, although it can slow down wiki page rendering if a page contains lots of attachments.

I slightly improved the Tomomi Yuzuriha's patch to avoid the slowdown caused by additional SQL query ("SELECT COUNT(*) FROM ..."). I replaced count method with length method. With this change, I think the slowdown that Mischa wrote will never happen.

Vanilla Redmine:

  Attachment Load (0.4ms)  SELECT "attachments".* FROM "attachments" WHERE "attachments"."container_id" = ? AND "attachments"."container_type" = ? ORDER BY attachments.created_on ASC, attachments.id ASC  [["container_id", 1], ["container_type", "WikiPage"]]
  Rendered wiki/_content.html.erb (147.0ms)
  CACHE Attachment Load (0.0ms)  SELECT "attachments".* FROM "attachments" WHERE "attachments"."container_id" = ? AND "attachments"."container_type" = ? ORDER BY attachments.created_on ASC, attachments.id ASC  [["container_id", 1], ["container_type", "WikiPage"]]

With Tomomi Yuzuriha's patch applied:

It requires one more query ("SELECT COUNT(*) FROM ..."). It can cause the slowdown as Mishca pointed out.

  Attachment Load (0.2ms)  SELECT "attachments".* FROM "attachments" WHERE "attachments"."container_id" = ? AND "attachments"."container_type" = ? ORDER BY attachments.created_on ASC, attachments.id ASC  [["container_id", 1], ["container_type", "WikiPage"]]
  Rendered wiki/_content.html.erb (74.0ms)
   (0.2ms)  SELECT COUNT(*) FROM "attachments" WHERE "attachments"."container_id" = ? AND "attachments"."container_type" = ?  [["container_id", 1], ["container_type", "WikiPage"]]
  CACHE Attachment Load (0.0ms)  SELECT "attachments".* FROM "attachments" WHERE "attachments"."container_id" = ? AND "attachments"."container_type" = ? ORDER BY attachments.created_on ASC, attachments.id ASC  [["container_id", 1], ["container_type", "WikiPage"]]

Replaced count with length:

Queries are identical with vanilla Redmine. There isn't "SELECT COUNT(*) FROM ..." which can cause the slowdown.

  Attachment Load (0.2ms)  SELECT "attachments".* FROM "attachments" WHERE "attachments"."container_id" = ? AND "attachments"."container_type" = ? ORDER BY attachments.created_on ASC, attachments.id ASC  [["container_id", 1], ["container_type", "WikiPage"]]
  Rendered wiki/_content.html.erb (151.1ms)
  CACHE Attachment Load (0.0ms)  SELECT "attachments".* FROM "attachments" WHERE "attachments"."container_id" = ? AND "attachments"."container_type" = ? ORDER BY attachments.created_on ASC, attachments.id ASC  [["container_id", 1], ["container_type", "WikiPage"]]

Actions

Copy link