Feature #27096
closed
Mark non-working days in calendar view
Added by Maxim Krušina about 7 years ago. Updated almost 6 years ago.
0%
Description
In global settings, we can set which are / are not working days - it should be nice to have it visually marked in project's calendar view
Files
| non-working-days.png (322 KB) non-working-days.png | Marius BĂLTEANU, 2018-09-05 21:10 | ||
| 0001-Move-calendar-day-classes-to-a-helper.patch (1.61 KB) 0001-Move-calendar-day-classes-to-a-helper.patch | Marius BĂLTEANU, 2018-12-18 07:37 | ||
| 0002-Add-nwday-class-to-non-working-days-in-calendar.patch (2.52 KB) 0002-Add-nwday-class-to-non-working-days-in-calendar.patch | Marius BĂLTEANU, 2019-01-07 05:11 |
Updated by 
Updated by Toshi MARUYAMA
Updated by Marius BĂLTEANU about 6 years ago
- File non-working-days.png non-working-days.png added
Maybe we can grey-out the non working days using the same style like the days from other months? Something like that:
Updated by Go MAEDA about 6 years ago
Marius BALTEANU wrote:
Maybe we can grey-out the non working days using the same style like the days from other months?
+1
I think it would be even better to use a different background color from dates of previous/next months.
Updated by Marius BĂLTEANU about 6 years ago
- Assignee set to Marius BĂLTEANU
Go MAEDA wrote:
+1
I think it would be even better to use a different background color from dates of previous/next months.
Yes, it could be an option. Let me see what can I do.
Updated by Marius BĂLTEANU almost 6 years ago
- File 0001-Move-calendar-day-classes-to-a-helper.patch 0001-Move-calendar-day-classes-to-a-helper.patch added
- File 0002-Add-non-working-class-to-non-working-days-in-calenda.patch added
- Assignee changed from Marius BĂLTEANU to Go MAEDA
- Target version set to Candidate for next major release
Go Maeda, attached the patches that mark the non working days in the calendars from Projects and My Page. I didn't apply any style on the class because I didn't have any idea (apart from the same style as the one from days from other month). Please feel free to add a style to my patches.
Updated by Marius BĂLTEANU almost 6 years ago
Go Maeda, did you have the chance to look over this feature?
Updated by Go MAEDA almost 6 years ago
- Assignee changed from Go MAEDA to Marius BĂLTEANU
Marius, thank you for writing the patch.
It looks OK except one thing. Do you think it is OK that the class name for non-working days is different from gantt? Although gantt already uses "nwday", your patch uses "non-working".
Updated by Marius BĂLTEANU almost 6 years ago
- File deleted (
0002-Add-non-working-class-to-non-working-days-in-calenda.patch)
Updated by Marius BĂLTEANU almost 6 years ago
- File 0002-Add-nwday-class-to-non-working-days-in-calendar.patch 0002-Add-nwday-class-to-non-working-days-in-calendar.patch added
- Assignee changed from Marius BĂLTEANU to Go MAEDA
Go MAEDA wrote:
It looks OK except one thing. Do you think it is OK that the class name for non-working days is different from gantt? Although gantt already uses "nwday", your patch uses "non-working".
For sure we should use the existing "nwday" class, but I didn't know about it. I've updated my second patch, thanks for pointing out.
Tests results here: https://gitlab.com/marius-balteanu/redmine/-/jobs/142133626
Updated by Go MAEDA almost 6 years ago
- Target version changed from Candidate for next major release to 4.1.0
Thank you for updating the patch, it looks good. Setting the target version to 4.1.0.
Updated by Go MAEDA almost 6 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Committed the patches. Thank you for improving Redmine.
And I have added a style for non-working days. The background color is the same with non-working days in gantt.
Updated by Go MAEDA almost 6 years ago
- Subject changed from Mark (somehow) non-working days in calendar view to Mark non-working days in calendar view