Redmine

Upload capture and error log.

Screenshot of migration error¶

Current Env¶

sh-4.3# rails about
About your application's environment
Rails version             5.1.2
Ruby version              2.4.1-p111 (x86_64-linux)
RubyGems version          2.6.11
Rack version              2.0.3
Middleware                Rack::Sendfile, Rack::ContentLength, ActionDispatch::Static, ActionDispatch::Executor, ActiveSupport::Cache::Strategy::LocalCache::Middleware, Rack::Runtime, Rack::MethodOverride, ActionDispatch::RequestId, ActionDispatch::RemoteIp, Rails::Rack::Logger, ActionDispatch::ShowExceptions, ActionDispatch::DebugExceptions, ActionDispatch::Reloader, ActionDispatch::Callbacks, ActionDispatch::Cookies, ActionDispatch::Session::CookieStore, ActionDispatch::Flash, Rack::Head, Rack::ConditionalGet, Rack::ETag, RequestStore::Middleware, Module
Application root          /tmp/redmine
Environment               development
Database adapter          mysql2
Database schema version   20170723112801

sh-4.3# git branch
* master
sh-4.3# git log 
commit fc1912442fed541c8d3a207ce71bbeb9569a32d1
Author: Jean-Philippe Lang <jp_lang@......>
Date:   Sun Oct 15 19:50:46 2017 +0000

    Adds changes from 3.3.5.

    git-svn-id: http://svn.redmine.org/redmine/trunk@17004 e93f8b46-1217-0410-a6f0-8f06a7374b81

I'm seeing this issue with both master branch and 3.4-stable on github

Current Env: OSX
$ rails about
About your application's environment
Rails version 5.1.2
Ruby version 2.3.0-p0 (x86_64-darwin16)
RubyGems version 2.5.1
Rack version 2.0.3
Middleware Rack::Sendfile, Rack::ContentLength, ActionDispatch::Static, ActionDispatch::Executor, ActiveSupport::Cache::Strategy::LocalCache::Middleware, Rack::Runtime, Rack::MethodOverride, ActionDispatch::RequestId, ActionDispatch::RemoteIp, Rails::Rack::Logger, ActionDispatch::ShowExceptions, ActionDispatch::DebugExceptions, ActionDispatch::Reloader, ActionDispatch::Callbacks, ActionDispatch::Cookies, ActionDispatch::Session::CookieStore, ActionDispatch::Flash, Rack::Head, Rack::ConditionalGet, Rack::ETag, RequestStore::Middleware, Module
Application root /Users/nishant/projects/ruby/redmine
Environment development
Database adapter mysql2
Database schema version 0

I tried this.

diff --git a/db/migrate/20150113194759_create_email_addresses.rb b/db/migrate/20150113194759_create_email_addresses.rb
--- a/db/migrate/20150113194759_create_email_addresses.rb
+++ b/db/migrate/20150113194759_create_email_addresses.rb
@@ -6,7 +6,7 @@ class CreateEmailAddresses < ActiveRecor
       t.column :is_default, :boolean, :null => false, :default => false
       t.column :notify, :boolean, :null => false, :default => true
       t.column :created_on, :timestamp, :null => false
-      t.column :updated_on, :timestamp, :null => false
+      t.column :updated_on, :timestamp, :null => false, default: -> { 'NOW()' }
     end
   end
 end

mysql> desc email_addresses;
+------------+--------------+------+-----+-------------------+-----------------------------+
| Field      | Type         | Null | Key | Default           | Extra                       |
+------------+--------------+------+-----+-------------------+-----------------------------+
| id         | int(11)      | NO   | PRI | NULL              | auto_increment              |
| user_id    | int(11)      | NO   | MUL | NULL              |                             |
| address    | varchar(255) | NO   |     | NULL              |                             |
| is_default | tinyint(1)   | NO   |     | 0                 |                             |
| notify     | tinyint(1)   | NO   |     | 1                 |                             |
| created_on | timestamp    | NO   |     | CURRENT_TIMESTAMP | on update CURRENT_TIMESTAMP |
| updated_on | timestamp    | NO   |     | CURRENT_TIMESTAMP |                             |
+------------+--------------+------+-----+-------------------+-----------------------------+
7 rows in set (0.00 sec)

I'm reassigning this defect to 4.0.0 because the Github issue was closed without any solution and this problem still blocks the migrations on a default Mysql 5.7. I'm considering this ticket a real issue.

I made some checks and it seems that the changes between rake db:migrate on Rails 4.2 and rake db:migrate on Rails 5.2 are quite big.

First of all, it seems that the :timestamp method from migrations generates different column types:

Redmine 3.4.6 with Rails 4.2

mysql> desc users;
+--------------------+--------------+------+-----+---------+----------------+
| Field              | Type         | Null | Key | Default | Extra          |
+--------------------+--------------+------+-----+---------+----------------+
| id                 | int(11)      | NO   | PRI | NULL    | auto_increment |
| login              | varchar(255) | NO   |     |         |                |
| hashed_password    | varchar(40)  | NO   |     |         |                |
| firstname          | varchar(30)  | NO   |     |         |                |
| lastname           | varchar(255) | NO   |     |         |                |
| admin              | tinyint(1)   | NO   |     | 0       |                |
| status             | int(11)      | NO   |     | 1       |                |
| last_login_on      | datetime     | YES  |     | NULL    |                |
| language           | varchar(5)   | YES  |     |         |                |
| auth_source_id     | int(11)      | YES  | MUL | NULL    |                |
| created_on         | datetime     | YES  |     | NULL    |                |
| updated_on         | datetime     | YES  |     | NULL    |                |
| type               | varchar(255) | YES  | MUL | NULL    |                |
| identity_url       | varchar(255) | YES  |     | NULL    |                |
| mail_notification  | varchar(255) | NO   |     |         |                |
| salt               | varchar(64)  | YES  |     | NULL    |                |
| must_change_passwd | tinyint(1)   | NO   |     | 0       |                |
| passwd_changed_on  | datetime     | YES  |     | NULL    |                |
+--------------------+--------------+------+-----+---------+----------------+
18 rows in set (0.00 sec)

Redmine 4.0.0 with Rails 5.2

mysql> desc redmine_test.users;
+--------------------+--------------+------+-----+---------+----------------+
| Field              | Type         | Null | Key | Default | Extra          |
+--------------------+--------------+------+-----+---------+----------------+
| id                 | int(11)      | NO   | PRI | NULL    | auto_increment |
| login              | varchar(255) | NO   |     |         |                |
| hashed_password    | varchar(40)  | NO   |     |         |                |
| firstname          | varchar(30)  | NO   |     |         |                |
| lastname           | varchar(255) | NO   |     |         |                |
| admin              | tinyint(1)   | NO   |     | 0       |                |
| status             | int(11)      | NO   |     | 1       |                |
| last_login_on      | datetime     | YES  |     | NULL    |                |
| language           | varchar(5)   | YES  |     |         |                |
| auth_source_id     | int(11)      | YES  | MUL | NULL    |                |
| created_on         | timestamp    | YES  |     | NULL    |                |
| updated_on         | timestamp    | YES  |     | NULL    |                |
| type               | varchar(255) | YES  | MUL | NULL    |                |
| identity_url       | varchar(255) | YES  |     | NULL    |                |
| mail_notification  | varchar(255) | NO   |     |         |                |
| salt               | varchar(64)  | YES  |     | NULL    |                |
| must_change_passwd | tinyint(1)   | NO   |     | 0       |                |
| passwd_changed_on  | datetime     | YES  |     | NULL    |                |
+--------------------+--------------+------+-----+---------+----------------+
18 rows in set (0.01 sec)

As can be observed, the columns created_on and updated_on on Rails 4.2 are of type :datetime, but in Rails 5.2, the type changed to :timestamp
This behaviour can be observed in all tables that have columns of type :timestamp in the migrations.

For me, the attached patch fixes the migration on Rails 5.2 and generates the same table as Rails 4.2. All tests pass.

Redmine 3.4.6 with Rails 4.2

mysql> desc email_addresses;
+------------+--------------+------+-----+---------+----------------+
| Field      | Type         | Null | Key | Default | Extra          |
+------------+--------------+------+-----+---------+----------------+
| id         | int(11)      | NO   | PRI | NULL    | auto_increment |
| user_id    | int(11)      | NO   | MUL | NULL    |                |
| address    | varchar(255) | NO   |     | NULL    |                |
| is_default | tinyint(1)   | NO   |     | 0       |                |
| notify     | tinyint(1)   | NO   |     | 1       |                |
| created_on | datetime     | NO   |     | NULL    |                |
| updated_on | datetime     | NO   |     | NULL    |                |
+------------+--------------+------+-----+---------+----------------+
7 rows in set (0.00 sec)

Redmine 4.0.0 with Rails 5.2

mysql> desc redmine_test.email_addresses;
+------------+--------------+------+-----+---------+----------------+
| Field      | Type         | Null | Key | Default | Extra          |
+------------+--------------+------+-----+---------+----------------+
| id         | int(11)      | NO   | PRI | NULL    | auto_increment |
| user_id    | int(11)      | NO   | MUL | NULL    |                |
| address    | varchar(255) | NO   |     | NULL    |                |
| is_default | tinyint(1)   | NO   |     | 0       |                |
| notify     | tinyint(1)   | NO   |     | 1       |                |
| created_on | datetime     | NO   |     | NULL    |                |
| updated_on | datetime     | NO   |     | NULL    |                |
+------------+--------------+------+-----+---------+----------------+
7 rows in set (0.00 sec)

Even if the versioned migration from Rails 5.2 says that the behaviour for old migrations will not be changed when you specify the version, in my tests, it doesn't work.
I'm not sure if what I said is 100% correct, but these are the results of my findings and understandings.

Also, if I'm right, I think that we should change ":timestamp" with ":datetime" in all migration files (this is Rails 5.2 default type, see Toshi's note 6).

I was able to reproduce with the details about your Mysql configuration.
Committed, thanks.

Removing the target version because I think this issue is a part of #23630.

The bug only existed in the trunk while migrating to Rails 5 and was not included in past releases, therefore it is not necessary to add this issue to the changelog.