Feature #27346
closed
Use the new pagination style for the calendars view
Added by Bernhard Rohloff about 7 years ago. Updated over 1 year ago.
0%
Description
This patch converts the previous and next month links in the calendars view into buttons in the new pagination style. It also aligns the buttons vertically with the input fields on the left.
Files
| calendars_prev_and_next_month_pagination_style_r17016.diff (1.58 KB) calendars_prev_and_next_month_pagination_style_r17016.diff | Bernhard Rohloff, 2017-11-01 07:34 | ||
| screenshot_calendars_buttons.png (20 KB) screenshot_calendars_buttons.png | Bernhard Rohloff, 2017-11-01 07:46 | ||
| 27346-v2.patch (1.53 KB) 27346-v2.patch | Go MAEDA, 2023-05-05 07:53 |
Related issues
Updated by Bernhard Rohloff about 7 years ago
This is the result of the patch...
Updated by Go MAEDA about 7 years ago
- Subject changed from Use the new pagination style for the calendars view. to Use the new pagination style for the calendars view
- Category changed from UI to Calendar
- Target version set to 4.1.0
It looks nice and improves the consistency of UI. I am setting target version to 4.1.0.
Thank you for posting the patch.
Updated by Marius BĂLTEANU about 7 years ago
- Related to Patch #21258: Use <ul> to do pagination, styling in a GitHub like manner with improved handling in responsive mode added
Updated by Marius BĂLTEANU about 6 years ago
This is another small change that can be included in 4.0.0.
Updated by Go MAEDA about 6 years ago
Marius BALTEANU wrote:
This is another small change that can be included in 4.0.0.
I have not committed this patch because this patch changes a style ".buttons". The change influences all pages which use the class, not only the calendar page.
Updated by Marius BĂLTEANU about 6 years ago
Go MAEDA wrote:
Marius BALTEANU wrote:
This is another small change that can be included in 4.0.0.
I have not committed this patch because this patch changes a style ".buttons". The change influences all pages which use the class, not only the calendar page.
Oh, I need to admit that I didn't see that change.
Updated by Bernhard Rohloff about 6 years ago
I'm currently on the road but I can have a look at the patch on Sunday.
At a first glance I think the new styles came into the patch by accident.
Updated by Bernhard Rohloff about 6 years ago
Ok, I've looked at the patch and the style changes for the 'buttons' class are necessary to geht the new buttons for previous and next month in line with the form controls on the left.
After nearly a year passed by since I've submitted this patch I don't think it's the right solution anymore and I'll submit a better one for 4.1.0.
Updated by Go MAEDA over 5 years ago
- Target version changed from 4.1.0 to Candidate for next major release
Updated by Go MAEDA over 1 year ago
- File 27346-v2.patch 27346-v2.patch added
- Target version changed from Candidate for next major release to 5.1.0
Go MAEDA wrote in #note-5:
I have not committed this patch because this patch changes a style ".buttons". The change influences all pages which use the class, not only the calendar page.
I slightly updated the patch. The new patch addresses the above point by setting margin-top against .controller-calendars p.buttons instead of p.buttons.
Setting the target version to 5.1.0.
Updated by Go MAEDA over 1 year ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the patch in r22235. Thank you.