Defect #27543
closedKey/value-pair custom field type not available to all customisable contents
0%
Description
The key/value-pair custom field type is currently limited to the same customisable contents as User and Version custom fields. For the key/value-pair custom field type this limitation is not necessary as the key/value-pairs are not project dependant.
The following patch removes the limitation inherited from the RecordList in the EnumerationFormat.
--- a/lib/redmine/field_format.rb
+++ b/lib/redmine/field_format.rb
@@ -723,6 +723,8 @@ module Redmine
end
class EnumerationFormat < RecordList
+ self.customized_class_names = nil
+
add 'enumeration'
self.form_partial = 'custom_fields/formats/enumeration'
Another possibility would be to move the limitation from the parent class RecordList to the child classes that need it (UserFormat, VersionFormat), but that would mean that other existing subclasses (e.g. from plugins) would need to be updated if they rely on this limitation.
Files
Updated by Go MAEDA almost 8 years ago
- Category set to Custom fields
- Target version set to Candidate for next major release
Updated by Takenori TAKAKI over 1 year ago
- File 27543-remove-inherited-limitation-with-test.patch 27543-remove-inherited-limitation-with-test.patch added
+1
I agree with Felix Schäfer Improvement.
I attach a patch with additional tests.
Updated by Takenori TAKAKI over 1 year ago
- File 27543-remove-inherited-limitation-with-test-2.patch 27543-remove-inherited-limitation-with-test-2.patch added
I attach a patch that adds tests to ensure the functionality introduced in note-2 operates as expected.
Updated by Go MAEDA over 1 year ago
- Target version changed from Candidate for next major release to 6.0.0
Setting the target version to 6.0.0.
Updated by Go MAEDA over 1 year ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch in r22834. Thank you.