Patch #27807: Use a unique way to check/uncheck a group/fieldset with checkboxes - Redmine

Actions

Copy link

Patch #27807

closed

Use a unique way to check/uncheck a group/fieldset with checkboxes

Added by Marius BĂLTEANU over 6 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Target version:

4.0.0

Start date:

Due date:

% Done:

Estimated time:

Description

Currently, there are 2 ways to check/uncheck a group/fieldset with checkboxes:

1. Using the green tick icon in screens like:
- New member modal
- Workflow, tab Status transitions

2. Using the explicit links "Check All/Uncheck All" in screens like
- New tracker form
- New custom field form

These 2 patches propose to replace the explicit links from the above mentioned screens (point 2) with the toggle feature.

In this way, will have a unique and consistent way to check/uncheck a group of checkboxes across the application.

I chose to use the version with the green tick because it requires less space than the explicit links and it fits better.
I'm not saying that the green tick is the best option, but this is an ongoing discussion (#27678).

Files

Download all files

0005-replace-check_all_links-in-new-tracker-form-with-too.patch (1.25 KB) 0005-replace-check_all_links-in-new-tracker-form-with-too.patch		Marius BĂLTEANU, 2017-12-16 11:04
0006-replace-check_all_links-in-new-custom-field-form-wit.patch (2.06 KB) 0006-replace-check_all_links-in-new-custom-field-form-wit.patch		Marius BĂLTEANU, 2017-12-16 11:04
Screen Shot 2017-12-16 at 12.05.42.png (53 KB) Screen Shot 2017-12-16 at 12.05.42.png		Marius BĂLTEANU, 2017-12-16 11:08
Screen Shot 2017-12-16 at 12.05.54.png (74.2 KB) Screen Shot 2017-12-16 at 12.05.54.png		Marius BĂLTEANU, 2017-12-16 11:08

Related issues

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

Tracker changed from Defect to Patch

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

File Screen Shot 2017-12-16 at 12.04.52.png added
File Screen Shot 2017-12-16 at 12.05.07.png added
File Screen Shot 2017-12-16 at 12.05.33.png added
File Screen Shot 2017-12-16 at 12.05.42.png Screen Shot 2017-12-16 at 12.05.42.png added
File Screen Shot 2017-12-16 at 12.05.54.png Screen Shot 2017-12-16 at 12.05.54.png added

Some screenshots

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

Related to Patch #27678: Make "Check all / Uncheck all" link noticeable added

Actions

Copy link

Updated by Mizuki ISHIKAWA over 6 years ago

+1
I think that this change will improve usability.

Actions

Copy link

Updated by Marius BĂLTEANU about 6 years ago

Related to Defect #28079: The green tick is positioned after the label in the new member modals added

Actions

Copy link

Updated by Marius BĂLTEANU about 6 years ago

I'm removing patches 0007 and 0008 because were committed in #28079.

Actions

Copy link

Updated by Marius BĂLTEANU about 6 years ago

File deleted (~~0007-use-regular-icon-icon-checked-classes.patch~~)

Actions

Copy link

Updated by Marius BĂLTEANU about 6 years ago

File deleted (~~0008-fix-icon-position-in-new-member-modal.patch~~)

Actions

Copy link

Updated by Go MAEDA about 6 years ago

I agree to fix the problem that green tick icons are missing on some pages.

But I am worried that patch 0005 and 0006, which delete existing UI elements, may cause confusion for users because the green tick icons are not so noticeable as Mizuki mentioned in #27678.

Actions

Copy link

#10

Updated by Marius BĂLTEANU about 6 years ago

Description updated (diff)

I've moved the patches that add the toggle checkboxes feature (the green tick) to several screens to this ticket (#28242).

In this one we can discuss more about replacing the "Check all | Uncheck all" links with the same toggle checkboxes mechanism in order to a have a unique an consistent way to check/uncheck a group of checkboxes across the application

Actions

Copy link

#11