Defect #28079
The green tick is positioned after the label in the new member modals
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | UI | |||
| Target version: | 3.4.5 | |||
| Resolution: | Fixed | Affected version: |
Description
This is a patch extracted from #27807 in order to fix it earlier (in a minor version)
The green tick is positioned after the label in the new member modals from:
- admin (Users -> Edit user -> Projects -> Add Project)
- project setting (Project setting -> Membership -> New members)
I've attached:
- two screenshots with the issue
- a patch that fixes these issues.
project_settings_membership.png (214 KB)
admin_membership.png (127 KB)
fix_tick_position_in_membership_modals.patch 
(2.68 KB)
remove_useless_empty_space.patch
(1.32 KB)
screenshoot.png (99.2 KB)
Related issues
Associated revisions
Fix: The green tick is positioned after the label in the new member modals (#28079).
Patch by Marius BALTEANU.
Remove useless empty spaces (#28079).
Patch by Marius BALTEANU.
History
#1
Updated by Marius BALTEANU over 3 years ago
- Related to Patch #27807: Use a unique way to check/uncheck a group/fieldset with checkboxes added
#2
Updated by Mischa The Evil over 3 years ago
- Description updated (diff)
- Target version set to Unplanned backlogs
LGTM.
#3
Updated by Marius BALTEANU over 3 years ago
Go Maeda, lets fix these UI issues in the next minor version.
#4
Updated by Go MAEDA over 3 years ago
- Target version changed from Unplanned backlogs to 3.4.5
This patch fixes UI inconsistency. In other pages, the green tick is placed before the label.
Setting target version to 3.4.5.
#5
Updated by Go MAEDA over 3 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Committed. Thank you for improving Redmine.
#6
Updated by Marius BALTEANU over 3 years ago
- File remove_useless_empty_space.patch added
- File screenshoot.png added
- Status changed from Closed to Reopened
Thanks for fixing these issues.
I'm attaching a small fix for my previous patches in order to remove the useless empty space before the label.
It has no impact in the frontend, but it shouldn't be there.
#7
Updated by Go MAEDA over 3 years ago
- Status changed from Reopened to Closed
Committed the patch #28079#note-6. Thank you.
#8
Updated by Marius BALTEANU over 3 years ago
#9
Updated by Go MAEDA over 3 years ago
- Assignee set to Go MAEDA