Project

General

Profile

Actions
Copy link

Defect #28079

closed

The green tick is positioned after the label in the new member modals

Added by Marius BĂLTEANU over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
UI
Target version:
3.4.5
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

This is a patch extracted from #27807 in order to fix it earlier (in a minor version)

The green tick is positioned after the label in the new member modals from:
- admin (Users -> Edit user -> Projects -> Add Project)
- project setting (Project setting -> Membership -> New members)

I've attached:
- two screenshots with the issue
- a patch that fixes these issues.

Files

Download all files
project_settings_membership.png (214 KB) project_settings_membership.png Marius BĂLTEANU, 2018-01-26 00:46
admin_membership.png (127 KB) admin_membership.png Marius BĂLTEANU, 2018-01-26 00:46
fix_tick_position_in_membership_modals.patch (2.68 KB) fix_tick_position_in_membership_modals.patch Marius BĂLTEANU, 2018-01-26 00:49
remove_useless_empty_space.patch (1.32 KB) remove_useless_empty_space.patch Marius BĂLTEANU, 2018-02-22 21:23
screenshoot.png (99.2 KB) screenshoot.png Marius BĂLTEANU, 2018-02-22 21:25

Related issues

Related to Redmine - Patch #27807: Use a unique way to check/uncheck a group/fieldset with checkboxes ClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Marius BĂLTEANU over 7 years ago

  • Related to Patch #27807: Use a unique way to check/uncheck a group/fieldset with checkboxes added
Actions
Copy link
 #2

Updated by Mischa The Evil over 7 years ago

  • Description updated (diff)
  • Target version set to Unplanned backlogs

LGTM.

Actions
Copy link
 #3

Updated by Marius BĂLTEANU over 7 years ago

Go Maeda, lets fix these UI issues in the next minor version.

Actions
Copy link
 #4

Updated by Go MAEDA over 7 years ago

  • Target version changed from Unplanned backlogs to 3.4.5

This patch fixes UI inconsistency. In other pages, the green tick is placed before the label.

Setting target version to 3.4.5.

Actions
Copy link
 #5

Updated by Go MAEDA over 7 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed. Thank you for improving Redmine.

Actions
Copy link
 #6

Updated by Marius BĂLTEANU over 7 years ago

Thanks for fixing these issues.

I'm attaching a small fix for my previous patches in order to remove the useless empty space before the label.

It has no impact in the frontend, but it shouldn't be there.

Actions
Copy link
 #7

Updated by Go MAEDA over 7 years ago

  • Status changed from Reopened to Closed

Committed the patch #28079#note-6. Thank you.

Actions
Copy link
 #8

Updated by Marius BĂLTEANU over 7 years ago

Go MAEDA wrote:

Committed the patch #28079#note-6. Thank you.

Great, thanks!

Actions
Copy link
 #9

Updated by Go MAEDA over 7 years ago

  • Assignee set to Go MAEDA
Actions
Copy link

Also available in: Atom PDF