Redmine

The attached patch adds an ATOM feed for the "revisions/changes" view.

With the patch applied to the latest trunk r17140, I encountered the following error when I opened RepositoriesController#changes page. Could you take a look at it?

ActionView::Template::Error (unable to convert unpermitted parameters to hash):
    22: <% end %>
    23:
    24: <% other_formats_links do |f| %>
    25:   <%= f.link_to 'Atom', :url => params.merge({:key => User.current.rss_key}) %>
    26: <% end %>
    27:
    28: <% html_title(l(:label_change_plural)) -%>

lib/redmine/views/other_formats_builder.rb:26:in `merge'
lib/redmine/views/other_formats_builder.rb:26:in `link_to'
app/views/repositories/changes.html.erb:25:in `block in _app_views_repositories_changes_html_erb___3745583827616173410_70126154703040'
app/helpers/application_helper.rb:526:in `other_formats_links'
app/views/repositories/changes.html.erb:24:in `_app_views_repositories_changes_html_erb___3745583827616173410_70126154703040'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'

Error log: 27831-error-log.txt

Go MAEDA wrote:

With the patch applied to the latest trunk r17140, I encountered the following error when I opened RepositoriesController#changes page. Could you take a look at it?

I can confirm the error, it seems there have been more changes regarding ATOM feeds in master than I thought. The previous patch I provided should work with current stable, not current trunk/master.

I have adapted the patch for master, please find the patch attached.

I fixed Felix's patch 27831-master.patch (mainly config/routes.rb). I attached a fixed patch.

Go MAEDA wrote:

I tested the patch with Redmine's bundled test fixtures and repositories. I get "404 The entry or revision was not found in the repository" error when I click "Atom" link on the changes page (e.g. /projects/ecookbook/repository/changes/subversion_test/helloworld.c).

I did a similar test. The ATOM feed has been output.

Started GET "/projects/ecookbook/repository/10/changes/subversion_test/helloworld.c.atom?key=0bff9fd16476ad80fac510da47667ac16c2acb43" for 127.0.0.1 at 2020-01-07 09:37:29 +0900
Processing by RepositoriesController#changes as ATOM
  Parameters: {"key"=>"0bff9fd16476ad80fac510da47667ac16c2acb43", "id"=>"ecookbook", "repository_id"=>"10", "path"=>"subversion_test/helloworld.c"}
 ..
  Rendering common/feed.atom.builder
(snip)
  Rendered common/feed.atom.builder (19.8ms)
 ..
Completed 200 OK in 85ms (Views: 21.2ms | ActiveRecord: 4.9ms)