Project

General

Profile

Actions
Copy link

Patch #28191

closed

Add assignable, issues_visibility, time_entries_visibility and users_visibility to Roles API response

Added by Alex Stanev over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
REST API
Target version:
4.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Currently we are missing global roles fields: assignable, issues_visibility, time_entries_visibility and users_visibility. The assignable one is pretty useful when editing issue via API.

Files

Download all files
extend-roles-api-fields.patch (566 Bytes) extend-roles-api-fields.patch Alex Stanev, 2018-02-14 15:38
extend-roles-api-fields_v2.patch (1.29 KB) extend-roles-api-fields_v2.patch Alex Stanev, 2018-02-28 19:17
Actions
Copy link
 #1

Updated by Marius BALTEANU over 5 years ago

Thanks for the patch.

Can you add some assertions to your patch? source:trunk/test/integration/api_test/roles_test.rb#L54
It'll increase the chances to be taken into consideration.

Actions
Copy link
 #2

Updated by Mischa The Evil over 5 years ago

  • Category changed from Permissions and roles to REST API
Actions
Copy link
 #3

Updated by Alex Stanev over 5 years ago

Adding assertions, all tests passed.

Actions
Copy link
 #4

Updated by Go MAEDA over 5 years ago

  • Target version set to Candidate for next major release
Actions
Copy link
 #5

Updated by Go MAEDA about 5 years ago

  • Target version changed from Candidate for next major release to 4.1.0

Setting target version to 4.1.0.

Actions
Copy link
 #6

Updated by Go MAEDA about 5 years ago

  • Subject changed from Extend roles API with all additional fields to Add assignable, issues_visibility, time_entries_visibility and users_visibility to Roles API response
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0

Committed. Thank you for your contribution.

Actions
Copy link

Also available in: Atom PDF