Feature #28492

Option not to block closing a parent issue when it has open subtask(s)

Added by César DJ Caësar 9114 over 2 years ago. Updated 13 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Issues
Target version:-
Resolution:

Description

Hello,

I saw that: r16108.

But actually, it could be great to be able to close a parent task.
Is it possible to allow this in the "configuration" of Redmine? For example:

"Allow a parent tracker to be closed even if the sub-task aren't: YES/NO".

Thanks

issue-28492.png (31 KB) Toshi MARUYAMA, 2019-09-18 07:45

issue-28492.diff Magnifier (4.09 KB) Toshi MARUYAMA, 2019-09-18 07:45

issue-28492.ver.2.diff Magnifier (4.8 KB) Toshi MARUYAMA, 2019-10-16 03:53

issue-28492.ver.2.png (35.6 KB) Toshi MARUYAMA, 2019-10-16 03:53

issue-28492.ver.3.diff Magnifier (4.88 KB) Toshi MARUYAMA, 2020-01-31 14:33

issue-28492-20200321.diff Magnifier (4.31 KB) Toshi MARUYAMA, 2020-03-20 16:16


Related issues

Related to Redmine - Feature #10989: Prevent parent issue from being closed if a child issue i... Closed
Related to Redmine - Feature #31322: Provide a way to automatically close all open subtasks to... New
Related to Redmine - Feature #31589: Show warning and the reason when the issue cannot be clos... Closed
Duplicated by Redmine - Feature #31321: Option not to block closing a parent issue when its subta... Closed

History

#1 Updated by Go MAEDA almost 2 years ago

  • Related to Feature #10989: Prevent parent issue from being closed if a child issue is open added

#2 Updated by Go MAEDA about 1 year ago

  • Duplicated by Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed added

#3 Updated by Toshi MARUYAMA 10 months ago

  • Description updated (diff)

#4 Updated by Toshi MARUYAMA 10 months ago

  • Related to Feature #31321: Option not to block closing a parent issue when its subtask is open added

#5 Updated by Toshi MARUYAMA 10 months ago

  • Subject changed from Close sub-tasks when closing a parent task to Option not to block closing a parent issue when its subtask is open

#6 Updated by Toshi MARUYAMA 10 months ago

  • Related to deleted (Feature #31321: Option not to block closing a parent issue when its subtask is open)

#7 Updated by Toshi MARUYAMA 10 months ago

  • Duplicated by Feature #31321: Option not to block closing a parent issue when its subtask is open added

#8 Updated by Toshi MARUYAMA 10 months ago

This is patch.

#9 Updated by Go MAEDA 10 months ago

Toshi MARUYAMA wrote:

This is patch.

Thank you for writing the patch. The feature is beneficial for some users.

But I think it is better to change the setting name because "Close parent issue when its subtask is open" looks like a setting to automatically close parent issues.

The following is my idea. Comments are welcome:

  • "Allow closing parent issue which has open subtasks"
  • "Allow closing parent issue whose subtasks are open"

#10 Updated by Toshi MARUYAMA 10 months ago

  • Duplicated by deleted (Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed)

#11 Updated by Toshi MARUYAMA 10 months ago

  • Related to Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed added

#12 Updated by Hinako Tajima 10 months ago

Toshi MARUYAMA, thank you for your contribution to writing the patch.
I agree with Go MAEDA to change the setting name to "Allow closing parent issue whose subtasks are open".

#13 Updated by Go MAEDA 10 months ago

  • Target version set to Candidate for next major release

#14 Updated by Toshi MARUYAMA 9 months ago

Hinako Tajima wrote:

Toshi MARUYAMA, thank you for your contribution to writing the patch.
I agree with Go MAEDA to change the setting name to "Allow closing parent issue whose subtasks are open".

This is new patch.

#15 Updated by Mitsuyoshi Kawabata 6 months ago

Do you need this request? In what use cases is it necessary?

#16 Updated by Toshi MARUYAMA 6 months ago

  • Related to Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s) added

#17 Updated by Toshi MARUYAMA 6 months ago

Mitsuyoshi Kawabata wrote:

Do you need this request? In what use cases is it necessary?

I think if #31322 is implemented, this feature is redundant.

#18 Updated by Mitsuyoshi Kawabata 6 months ago

Let me clear my point, I think allowing a parent issue to be closed when subtasks are still open is not really necessary.
How about just #31589 ? It would be simple and clear.

#19 Updated by Mischa The Evil 6 months ago

  • Subject changed from Option not to block closing a parent issue when its subtask is open to Option not to block closing a parent issue when it has open subtask(s)

FWIW: This issue is not related/being superseded by either #31322 or #31589. See my explanation in #31589#note-21.

Regarding this feature: I tend to agree with Mitsuyoshi Kawabata that I'm not seeing clear use-cases where it is logical to have closed parent issues with open subtasks. I'd like some more feedback on this matter.

Though, if the decision is made to add this configuration option nevertheless, I'd propose the following T9N for the string setting_close_parent_issue_whose_subtasks_are_open: "Allow closed parent issues with open subtasks" and a similar I18n string and setting name.

#20 Updated by Toshi MARUYAMA 5 months ago

Mischa The Evil wrote:

I'd propose the following T9N for the string setting_close_parent_issue_whose_subtasks_are_open: "Allow closed parent issues with open subtasks" and a similar I18n string and setting name.

Changed.

#21 Updated by Go MAEDA 4 months ago

  • Target version deleted (Candidate for next major release)

#22 Updated by Toshi MARUYAMA 4 months ago

Rebased on trunk r19598 because r19570 caused conflict.

#23 Updated by Felix Schäfer 13 days ago

Some not-so-quick notes from Planio regarding this issue: r16108 was a breaking change for our existing users, some of which depended on and had built workflows around being able to have closed parent issues with open child issues. To alleviate this issue for existing users we have back ported the diff attached to this issue and enabled the setting to restore the "old" behaviour for existing users. New users will use the new behaviour by default.

We understand the need to make breaking changes sometimes, though having a setting would make that less breaking of a change for us: We could then set existing users to use the before breaking change behaviour and new users with the after breaking change behaviour.

We have discussed this matter internally in addition to already reading what has been discussed here. We also currently have no use-case for open subissues with closed parent issues, but this does not mean it is not a valid use-case. Several Planio users were impacted when we introduced this change on Planio.

We think Redmine is a very capable, malleable and configurable system and would like to contribute to keep it that way. Redmine does not impose certain types of trackers (you can configure more than just "Bug", "Feature" and "Support"), can be configured with arbitrary statuses and workflows in those statuses, Redmine can even have custom fields for issues and other things. We feel it is antithetical to the configurability of Redmine to not have a setting for this.

While thinking about this we also had an idea that might help assuage some concerns regarding this setting. We think adding this setting to trackers instead of a global setting could allow for more rich configurations and workflows in Redmine. You could then configure trackers to allow or to not allow closing when there are open subissues and vice-versa. Maybe the "inverse" setting would also be helpful: automatically closing parent issues with a certain tracker when all subissues are closed.

Thank you for reading and thank you for your work and care with Redmine.

Also available in: Atom PDF