Feature #28492
open
Option not to block closing a parent issue when it has open subtask(s)
Added by César DJ Caësar 9114 about 6 years ago. Updated over 1 year ago.
0%
Description
Hello,
I saw that: r16108.
But actually, it could be great to be able to close a parent task.
Is it possible to allow this in the "configuration" of Redmine? For example:
"Allow a parent tracker to be closed even if the sub-task aren't: YES/NO".
Thanks
Files
| issue-28492.png (31 KB) issue-28492.png | Toshi MARUYAMA, 2019-09-18 07:45 | ||
| issue-28492.diff (4.09 KB) issue-28492.diff | Toshi MARUYAMA, 2019-09-18 07:45 | ||
| issue-28492.ver.2.diff (4.8 KB) issue-28492.ver.2.diff | Toshi MARUYAMA, 2019-10-16 03:53 | ||
| issue-28492.ver.2.png (35.6 KB) issue-28492.ver.2.png | Toshi MARUYAMA, 2019-10-16 03:53 | ||
| issue-28492.ver.3.diff (4.88 KB) issue-28492.ver.3.diff | Toshi MARUYAMA, 2020-01-31 14:33 | ||
| issue-28492-20200321.diff (4.31 KB) issue-28492-20200321.diff | Toshi MARUYAMA, 2020-03-20 16:16 |
Related issues
Updated by Go MAEDA over 5 years ago
- Related to Feature #10989: Prevent parent issue from being closed if a child issue is open added
Updated by Go MAEDA almost 5 years ago
- Has duplicate Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed added
Updated by Toshi MARUYAMA over 4 years ago
- Related to Feature #31321: Option not to block closing a parent issue when its subtask is open added
Updated by Toshi MARUYAMA over 4 years ago
- Subject changed from Close sub-tasks when closing a parent task to Option not to block closing a parent issue when its subtask is open
Updated by Toshi MARUYAMA over 4 years ago
- Related to deleted (Feature #31321: Option not to block closing a parent issue when its subtask is open)
Updated by Toshi MARUYAMA over 4 years ago
- Has duplicate Feature #31321: Option not to block closing a parent issue when its subtask is open added
Updated by Toshi MARUYAMA over 4 years ago
- File issue-28492.png issue-28492.png added
- File issue-28492.diff issue-28492.diff added
This is patch.
Updated by Go MAEDA over 4 years ago
Toshi MARUYAMA wrote:
This is patch.
Thank you for writing the patch. The feature is beneficial for some users.
But I think it is better to change the setting name because "Close parent issue when its subtask is open" looks like a setting to automatically close parent issues.
The following is my idea. Comments are welcome:
- "Allow closing parent issue which has open subtasks"
- "Allow closing parent issue whose subtasks are open"
Updated by Toshi MARUYAMA over 4 years ago
- Has duplicate deleted (Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed)
Updated by Toshi MARUYAMA over 4 years ago
- Related to Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed added
Updated by Hinako Tajima over 4 years ago
Toshi MARUYAMA, thank you for your contribution to writing the patch.
I agree with Go MAEDA to change the setting name to "Allow closing parent issue whose subtasks are open".
Updated by Go MAEDA over 4 years ago
- Target version set to Candidate for next major release
Updated by Toshi MARUYAMA over 4 years ago
- File issue-28492.ver.2.diff issue-28492.ver.2.diff added
- File issue-28492.ver.2.png issue-28492.ver.2.png added
Hinako Tajima wrote:
Toshi MARUYAMA, thank you for your contribution to writing the patch.
I agree with Go MAEDA to change the setting name to "Allow closing parent issue whose subtasks are open".
This is new patch.
Updated by Mitsuyoshi Kawabata over 4 years ago
Do you need this request? In what use cases is it necessary?
Updated by Toshi MARUYAMA over 4 years ago
- Related to Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s) added
Updated by Toshi MARUYAMA over 4 years ago
Mitsuyoshi Kawabata wrote:
Do you need this request? In what use cases is it necessary?
I think if #31322 is implemented, this feature is redundant.
Updated by Mitsuyoshi Kawabata over 4 years ago
Let me clear my point, I think allowing a parent issue to be closed when subtasks are still open is not really necessary.
How about just #31589 ? It would be simple and clear.
Updated by Mischa The Evil over 4 years ago
- Subject changed from Option not to block closing a parent issue when its subtask is open to Option not to block closing a parent issue when it has open subtask(s)
FWIW: This issue is not related/being superseded by either #31322 or #31589. See my explanation in #31589#note-21.
Regarding this feature: I tend to agree with Mitsuyoshi Kawabata that I'm not seeing clear use-cases where it is logical to have closed parent issues with open subtasks. I'd like some more feedback on this matter.
Though, if the decision is made to add this configuration option nevertheless, I'd propose the following T9N for the string setting_close_parent_issue_whose_subtasks_are_open: "Allow closed parent issues with open subtasks" and a similar I18n string and setting name.
Updated by Toshi MARUYAMA about 4 years ago
- File issue-28492.ver.3.diff issue-28492.ver.3.diff added
Mischa The Evil wrote:
I'd propose the following T9N for the string
setting_close_parent_issue_whose_subtasks_are_open: "Allow closed parent issues with open subtasks" and a similar I18n string and setting name.
Changed.
Updated by Go MAEDA about 4 years ago
- Target version deleted (
Candidate for next major release)
Updated by Toshi MARUYAMA about 4 years ago
Updated by Felix Schäfer almost 4 years ago
Some not-so-quick notes from Planio regarding this issue: r16108 was a breaking change for our existing users, some of which depended on and had built workflows around being able to have closed parent issues with open child issues. To alleviate this issue for existing users we have back ported the diff attached to this issue and enabled the setting to restore the "old" behaviour for existing users. New users will use the new behaviour by default.
We understand the need to make breaking changes sometimes, though having a setting would make that less breaking of a change for us: We could then set existing users to use the before breaking change behaviour and new users with the after breaking change behaviour.
We have discussed this matter internally in addition to already reading what has been discussed here. We also currently have no use-case for open subissues with closed parent issues, but this does not mean it is not a valid use-case. Several Planio users were impacted when we introduced this change on Planio.
We think Redmine is a very capable, malleable and configurable system and would like to contribute to keep it that way. Redmine does not impose certain types of trackers (you can configure more than just "Bug", "Feature" and "Support"), can be configured with arbitrary statuses and workflows in those statuses, Redmine can even have custom fields for issues and other things. We feel it is antithetical to the configurability of Redmine to not have a setting for this.
While thinking about this we also had an idea that might help assuage some concerns regarding this setting. We think adding this setting to trackers instead of a global setting could allow for more rich configurations and workflows in Redmine. You could then configure trackers to allow or to not allow closing when there are open subissues and vice-versa. Maybe the "inverse" setting would also be helpful: automatically closing parent issues with a certain tracker when all subissues are closed.
Thank you for reading and thank you for your work and care with Redmine.
Updated by Dennis Buehring over 1 year ago
I know this is an older issue, but we just ran into this feature/issue because we jumped from Redmine 3.x.x to 4.2.7
Personally i dont see a need for closed issues with open sub-issues... but it seems our users decided otherwise over the years.
I agree with Felix that this shouldn't be a global setting, but it should be configurable somewhere.. e.g. project or tracker level
Felix Schäfer did you stick with your backport ?