Feature #29041


Update session token only once per minute

Added by Pavel Rosický over 5 years ago. Updated almost 2 years ago.

Target version:
Start date:
Due date:
% Done:


Estimated time:


this is simmilar to #28952

if Rails.application.config.redmine_verify_sessions is enabled, basically each read request triggers an update to tokens table. This is bad for performance because it blocks the database.
My patch transforms the update query into a select query that doesn't block on heavy load. We could actually update the token only once per hour which is the minimum available setting for Setting.session_lifetime and Setting.session_timeout, but redmine modifications could use smaller values, so I choose 1 minute interval. Smaller session_timeout then 1 minute won't work now, but I think such small timeout doesn't make much sense.


user.rb.patch (644 Bytes) user.rb.patch Pavel Rosický, 2018-06-17 19:55
sessions_controller_test.rb.patch (865 Bytes) sessions_controller_test.rb.patch Pavel Rosický, 2018-06-17 19:55
user.rb.patch (665 Bytes) user.rb.patch Pavel Rosický, 2018-06-18 11:05
29041.patch (1.64 KB) 29041.patch Patch by Pavel Rosický Go MAEDA, 2022-01-20 08:28

Related issues

Related to Redmine - Feature #28952: Update User#last_login_on only once per minuteClosedJean-Philippe Lang

Actions #1

Updated by Marius BALTEANU over 5 years ago

  • Related to Feature #28952: Update User#last_login_on only once per minute added
Actions #3

Updated by Pavel Rosický about 5 years ago

ping Marius BALTEANU

Actions #4

Updated by Marius BALTEANU about 5 years ago

Pavel Rosický wrote:

ping Marius BALTEANU

Pong. I've missed something?

Actions #5

Updated by Pavel Rosický about 5 years ago

if you have time, could you review?

GET requests shouldn't update a database all the time. It's even more relevant for #29513

disabling Rails.application.config.redmine_verify_sessions isn't an option because it makes Redmine vulnerable

are there any security concerns about this change?

Actions #6

Updated by Go MAEDA almost 2 years ago

Combined user.rb.patch and sessions_controller_test.rb.patch.

Actions #7

Updated by Holger Just almost 2 years ago

I support the approach to reduce write traffic to the database. With this patch, the write contention on the tokens table and the Redmine database in general should be reduced quite a bit.

At first, I though that we would need to check whether we have only one valid token for the maximum query too. Turns out that there is a unique index on the tokens.value column in the database. As such, we are guaranteed to have only exactly zero or one token with a given value in the database. As both of these cases are checked by the patch, I think it should be fine and as secure as the previous version.

The slight reduction in accuracy is acceptable as the value is only used for session expiration where the difference of at most one minute is negligible. Enforcing session timeouts of less than one minute is not useful and does not need to be supported as it would effectively reduce the session to be only useful for (more-or-less) a single request.

Actions #8

Updated by Go MAEDA almost 2 years ago

  • Target version changed from Candidate for next major release to 5.0.0

Setting the target version to 5.0.0.

Actions #9

Updated by Go MAEDA almost 2 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you.


Also available in: Atom PDF