Redmine

+1

P.S. I'm thinking... there is lots of things (from minor fixes to huge features) that numerous developers out there had already implemented as plugins, which probably should have been in Redmine in the first place. Maybe one of the major plans of the community in the future could be to conspire with plugin developers in order to have them (or us, if they allow it) to port their code into the actual patches. This could be time saving for everyone, as we d be skipping the need for doing it from scratch I guess. :D

I think it will be better to have a snooze mechanism instead of just dropping the notifications. Also, the non-working days from admin is quite limited, we should have a way for each user to set his working days and hours.

Marius BALTEANU wrote in #note-7:

I think it will be better to have a snooze mechanism instead of just dropping the notifications.

Does the snooze mechanism mean, for instance, if Saturday and Sunday are days off, that you will receive three emails on Monday covering Saturday, Sunday, and Monday? In the case of reminder emails, since they display tickets whose due dates are either approaching or have passed within N days, I think stopping the reminders for Saturday and Sunday wouldn’t matter as the Monday reminder would encompass the information from the reminders of Saturday and Sunday.

Also, the non-working days from admin is quite limited, we should have a way for each user to set his working days and hours.

I agree that it would be good to be able to set individual non-working days for each user. Furthermore, it would be great if it was possible to set other non-working days of the week, rather than simply specifying the day.

Sorry, I haven't fully understand this issue when I read it firstly. So this new setting affects only the reminders that are sent using the rake task rake redmine:send_reminders and it doesn't apply to the usual mail notifications that are sent after specific events in the projects?

Marius BALTEANU wrote in #note-9:

Sorry, I haven't fully understand this issue when I read it firstly. So this new setting affects only the reminders that are sent using the rake task rake redmine:send_reminders and it doesn't apply to the usual mail notifications that are sent after specific events in the projects?

Yes, that's correct. The patch modifies the Mailer#reminders method, and Mailer#reminders is only called by the rake task rake redmine:send_reminders.

Thanks, it's clear now.

I'm not sure about this option because as a user, I don't have any visibility in Redmine UI about reminders and administrators already have some basic flexibility to send these reminders only during working days when they are setting up the cron. We can improve this by adding a flag to redmine:send_reminders to send notification only during working days and then the administrator can have the cron running daily and Redmine choose when to send or not the notification based on the Setting.non_working_week_days.

Coming back to user notification preferences, I'm more in favour of adding a "I don't want to be notified outside work days/hours" option which should apply to all notifications, not only reminders. Later on, we can add the "snooze" mechanism on top of this (reminders should be excluded from this).

If we take more feedback on this and agree which solution is better, I think we can include this with all the notification improvements that are under review right now.

Marius BALTEANU wrote in #note-11:

Thanks, it's clear now.

I'm not sure about this option because as a user, I don't have any visibility in Redmine UI about reminders and administrators already have some basic flexibility to send these reminders only during working days when they are setting up the cron. We can improve this by adding a flag to redmine:send_reminders to send notification only during working days and then the administrator can have the cron running daily and Redmine choose when to send or not the notification based on the Setting.non_working_week_days.

I've found #20121 for this flag.