Feature #30776

Drag and drop file upload to file type custom field

Added by VD DV over 3 years ago. Updated over 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Custom fields
Target version:4.2.0
Resolution:Fixed

Description

Drag and drop file to "file custom field" is not behaving as expected. File is attached as regular file insted to Custom field.
Demonstration is attached at "file_dragNdrop.gif".

file_dragNdrop.gif - Defect demonstration (436 KB) VD DV, 2019-02-08 10:49

appearance-of-patch-applied.gif (559 KB) Mizuki ISHIKAWA, 2020-09-28 06:31

fix-30776.diff Magnifier (4.08 KB) Mizuki ISHIKAWA, 2020-09-28 06:36

Associated revisions

Revision 20712
Added by Go MAEDA over 1 year ago

Drag and drop file upload to file type custom field (#30776).

Patch by Mizuki ISHIKAWA.

History

#1 Updated by Go MAEDA about 3 years ago

  • Category changed from UI to Custom fields
  • Status changed from New to Confirmed

#2 Updated by VD DV almost 3 years ago

Is this defect planned to be fixed soon?

#3 Updated by Mizuki ISHIKAWA over 1 year ago

I have attached a patch to fix this issue.

#4 Updated by Go MAEDA over 1 year ago

  • Target version set to Candidate for next major release

#5 Updated by Go MAEDA over 1 year ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#6 Updated by Go MAEDA over 1 year ago

  • Tracker changed from Defect to Feature
  • Subject changed from Drag and drop file to "file custom field" is not behaving as expected to Drag and drop file upload to file type custom field
  • Status changed from Confirmed to New

#7 Updated by Go MAEDA over 1 year ago

Mizuki ISHIKAWA wrote:

I have attached a patch to fix this issue.

Thank you for posting the patch but I found a strange behavior when trying to upload files.

An error message :error_attachments_too_many is displayed when you attempt to drop two or more files. It is OK. However, you will see a dialog box with the message (n - 1) times. For example, if you drop 10 files to a file type custom field, you have to click the "OK" button 9 times to close dialog boxes.

#8 Updated by Mizuki ISHIKAWA over 1 year ago

Go MAEDA wrote:

Mizuki ISHIKAWA wrote:

I have attached a patch to fix this issue.

Thank you for posting the patch but I found a strange behavior when trying to upload files.

An error message :error_attachments_too_many is displayed when you attempt to drop two or more files. It is OK. However, you will see a dialog box with the message (n - 1) times. For example, if you drop 10 files to a file type custom field, you have to click the "OK" button 9 times to close dialog boxes.

This is a problem that occurs not only with custom fields, but also with regular file attachments.(If you attach 20 files at the same time, you need to delete the alert 10 times.)
Probably another issue related to #18555.

#9 Updated by Mizuki ISHIKAWA over 1 year ago

Go MAEDA wrote:

Mizuki ISHIKAWA wrote:

I have attached a patch to fix this issue.

Thank you for posting the patch but I found a strange behavior when trying to upload files.

An error message :error_attachments_too_many is displayed when you attempt to drop two or more files. It is OK. However, you will see a dialog box with the message (n - 1) times. For example, if you drop 10 files to a file type custom field, you have to click the "OK" button 9 times to close dialog boxes.

I have attached a patch for this issue. https://www.redmine.org/issues/18555#note-10

#10 Updated by Go MAEDA over 1 year ago

Go MAEDA wrote:

Mizuki ISHIKAWA wrote:

I have attached a patch to fix this issue.

Thank you for posting the patch but I found a strange behavior when trying to upload files.

An error message :error_attachments_too_many is displayed when you attempt to drop two or more files. It is OK. However, you will see a dialog box with the message (n - 1) times. For example, if you drop 10 files to a file type custom field, you have to click the "OK" button 9 times to close dialog boxes.

Fixed in r20711.

#11 Updated by Go MAEDA over 1 year ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

Also available in: Atom PDF