Patch #31066
closed
Show projects using a table instead of an unordered list in the user profile page
Added by Takenori TAKAKI over 5 years ago. Updated over 5 years ago.
Description
I felt that the project list on the Profile page looks better 'table' style than 'ul' style. Especially on users with a large number of registered projects.
| 'ul' style | 'table' style | |
 |
==> |  |
Files
| users-memberships-ul.png (204 KB) users-memberships-ul.png | Takenori TAKAKI, 2019-03-20 08:35 | ||
| users-memberships-table.png (205 KB) users-memberships-table.png | Takenori TAKAKI, 2019-03-20 08:36 | ||
| 31066.patch (2.18 KB) 31066.patch | Takenori TAKAKI, 2019-03-20 09:11 | ||
| projects-indented@2x.png (30.5 KB) projects-indented@2x.png | Go MAEDA, 2019-03-20 15:11 | ||
| users-memberships-indented-table.png (89.5 KB) users-memberships-indented-table.png | Takenori TAKAKI, 2019-03-22 05:01 | ||
| 31066-indent-subproject.patch (2.4 KB) 31066-indent-subproject.patch | Takenori TAKAKI, 2019-03-22 05:03 | ||
| 31066-fix-broken-tests.patch (2.41 KB) 31066-fix-broken-tests.patch | Takenori TAKAKI, 2019-03-22 14:55 | ||
| 31066-group-memberships-by-project.patch (2.45 KB) 31066-group-memberships-by-project.patch | Go MAEDA, 2019-03-26 03:37 |
Updated by Takenori TAKAKI over 5 years ago
- File 31066.patch 31066.patch added
I made a patch and attached it.
Updated by Bernhard Rohloff over 5 years ago
+1 Looks very clean.
I'll test it when I find a free time slot.
Updated by Go MAEDA over 5 years ago
- File projects-indented@2x.png projects-indented@2x.png added
- Target version set to Candidate for next major release
Thank you for submitting the patch.
Takenori Takaki, I think it will be even better if subprojects are indented like admin/projects page. Is it possible?
Updated by Takenori TAKAKI over 5 years ago
- File users-memberships-indented-table.png users-memberships-indented-table.png added
- File 31066-indent-subproject.patch 31066-indent-subproject.patch added
Maeda-san, Thank you for your feedback!
I also think that indented lists are better to see.
It is possible to indent in subprojects, by changing like the attached patch.
Updated by Go MAEDA over 5 years ago
Thank you for the really nice improvement! But I encountered the following error while running test suites. Could you look into this?
Failure: UsersControllerTest#test_show_displays_memberships_based_on_project_visibility [/Users/maeda/redmines/redmine-trunk/test/functional/users_controller_test.rb:176]: Expected at least 1 element matching "td:nth-of-type(1)>a", found 0.. Expected 0 to be >= 1. bin/rails test test/functional/users_controller_test.rb:171
Updated by Takenori TAKAKI over 5 years ago
Go MAEDA wrote:
Thank you for the really nice improvement! But I encountered the following error while running test suites. Could you look into this?
Oops...Sorry...I could't notice the test broken.
I repaired the broken tests.
Updated by Go MAEDA over 5 years ago
- Target version changed from Candidate for next major release to 4.1.0
LGTM. Setting the target version to 4.1.0.
Updated by Go MAEDA over 5 years ago
- File 31066-group-memberships-by-project.patch added
I have slightly changed 31066-fix-broken-tests.patch.
- Use
Enumerable#group_byoutside the loop in order to avoid usingEnumerable#selectinside the loop. Maybe this is more efficient - Remove "members" class from the table because "width: 45%" for td.roles looks too wide
Updated by Go MAEDA over 5 years ago
Updated by Go MAEDA over 5 years ago
- File deleted (
31066-group-memberships-by-project.patch)
Updated by Go MAEDA over 5 years ago
- Subject changed from Change style of projects list from "ul" to "table", displayed on user profile to Show projects using a table instead of an unordered list in the user profile page
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed. Thanks.