Redmine

Please let me know the following points:

1. How do you rewrite your plugin if the patch is merged?
2. Sorry for the basic question but what does the word "renderigns" in the method name mean?

But this means that only the last plugins loaded will be reflected.

If `script_format_adapter` is updated by some plugins, will only the plugin loaded last be reflected?

If `script_format_adapter` is updated by some plugins, will only the plugin loaded last be reflected?

Of course there may be so.
But for plugins that add buttons to the toolbar with additional scripts, this change allows them to co-exist.
Under the current, it can not even do it.

But for plugins that add buttons to the toolbar with additional scripts, this change allows them to co-exist.
Under the current, it can not even do it.

Maybe I miss the point, but in this case, can't we solve conflicts just by appending plugin's assets like this?

# ref. https://github.com/pinzolo/redmine_persist_wfmt/pull/15

module Pwfmt::MarkdownHelperPatch
  # snip

  def heads_for_wiki_formatter
    # loads all default assets and possibly other plugins' assets
    super

    unless @pwfmt_heads_for_wiki_formatter_included
      content_for :header_tags do
        # overwrites default toolbar buttons
        javascript_include_tag('toolbar', plugin: 'redmine_persist_wfmt')
      end
      @pwfmt_heads_for_wiki_formatter_included = true
    end
  end
end

Thanks to your pull request.
I merged it.
It solved my problem.

Masato NODA wrote:

It solved my problem.

Can we remove this issue from 4.1.0?

Can we remove this issue from 4.1.0?

Yes, OK.
If I wil have a problem, I will propose again.