Feature #31322
open
Provide a way to automatically close all open subtasks too when a parent issue is being closed
Added by Hinako Tajima almost 5 years ago. Updated almost 4 years ago.
0%
Description
I wish to add the function of reminder which shows up like pop-up screen to ask for closing the subtask when the parent issue is closed.
親チケットが閉じられたときに、子チケットを閉じるように求める、ポップアップ画面が表示されるようなリマインダー機能を追加してほしい。
Files
Related issues
Updated by Go MAEDA almost 5 years ago
- Related to Feature #31321: Option not to block closing a parent issue when its subtask is open added
Updated by Go MAEDA almost 5 years ago
- Status changed from New to Closed
- Resolution set to Duplicate
Closing as a duplicate of #28492.
Updated by Go MAEDA almost 5 years ago
- Is duplicate of Feature #28492: Option not to block closing a parent issue when it has open subtask(s) added
Updated by Toshi MARUYAMA over 4 years ago
- Subject changed from Close subtasks along with a parent issue. to Confirming to close a parent issue when its subtask is open
- Status changed from Closed to New
- Resolution deleted (
Duplicate)
I don't think this issue is duplicate of #28492.
Updated by Toshi MARUYAMA over 4 years ago
- Is duplicate of deleted (Feature #28492: Option not to block closing a parent issue when it has open subtask(s))
Updated by Toshi MARUYAMA over 4 years ago
- Related to Feature #28492: Option not to block closing a parent issue when it has open subtask(s) added
Updated by Toshi MARUYAMA over 4 years ago
- File issue-31322.diff issue-31322.diff added
This is POC.
There is no test.
You need apply #28492 patch first.
Updated by Toshi MARUYAMA over 4 years ago
- File issue-31322-ver.2.diff issue-31322-ver.2.diff added
Simplified.
Updated by Toshi MARUYAMA over 4 years ago
$ LC_ALL=en_US.UTF-8 firefox
Updated by Toshi MARUYAMA over 4 years ago
- File issue-31322-ver.3.diff issue-31322-ver.3.diff added
This is new POC version.
There is still no test.
Updated by Toshi MARUYAMA over 4 years ago
- File issue-31322.ver.4.png issue-31322.ver.4.png added
- File issue-31322.ver.4.diff issue-31322.ver.4.diff added
This patch has test.
You need to apply #28492#note-14 patch first.
Updated by Toshi MARUYAMA over 4 years ago
Previous patch uses complicated javascript.
This patch rewrite to use jQuery submit event.
Previous patch uses client html elements to check whether subtask is open or not.
So it cannot check invisible issue.
This patch uses ajax and check in server.
You need to apply #28492#note-14 patch first.
Updated by Toshi MARUYAMA over 4 years ago
- File 20191218-02-ajax-modal-form.png 20191218-02-ajax-modal-form.png added
- File 20191218-02-ajax-modal-form.diff 20191218-02-ajax-modal-form.diff added
This is additional patch to previous patch.
This patch replaces Javascript confirm dialog to ajax modal form.
Updated by Toshi MARUYAMA over 4 years ago
- File 20191218-03-close-all-open-subtasks.diff 20191218-03-close-all-open-subtasks.diff added
- File 20191218-03-close-all-open-subtasks.png 20191218-03-close-all-open-subtasks.png added
- Subject changed from Confirming to close a parent issue when its subtask is open to Close all open subtasks when parent issue to be closed
This is additional patch to previous patch.
- All open subtasks are visible
- Selected status is allowed in all open subtasks
In this case this dialog opens.
If not, previous note dialog opens.
Updated by Toshi MARUYAMA over 4 years ago
- Related to Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s) added
Updated by Mitsuyoshi Kawabata over 4 years ago
Regarding Maruyama's patches, how about just #31589? It would be simple and clear.
Updated by Mischa The Evil over 4 years ago
- Subject changed from Close all open subtasks when parent issue to be closed to Provide a way to automatically close all open subtasks too when a parent issue is being closed
FWIW: This issue is not related/being superseded by either #28492 or #31589. See my explanation in #31589#note-21.
@Toshi MARUYAMA: It has become very hard to review your patches for this feature. Can you provide all your changes for this feature in a single patch and clearly specify which requirements it has (like a dependency on an implementation for issue #28492)?
Updated by Toshi MARUYAMA over 4 years ago
- File 20200131-series.diff added
- File 20200131-collapse.diff added
Mischa The Evil wrote:
@Toshi MARUYAMA: It has become very hard to review your patches for this feature. Can you provide all your changes for this feature in a single patch and clearly specify which requirements it has (like a dependency on an implementation for issue #28492)?
Done.
- 20200131-series.diff has contains several revisions
- 20200131-collapse.diff collapses 20200131-series.diff revisions to one diff
These depend on #28492#note-20 issue-28492.ver.3.diff.
Updated by Toshi MARUYAMA over 4 years ago
- File 20200131-collapse.diff 20200131-collapse.diff added
- File 20200131-series.diff 20200131-series.diff added
Fix indents.
Updated by Toshi MARUYAMA over 4 years ago
- File deleted (
20200131-collapse.diff)
Updated by Toshi MARUYAMA almost 4 years ago
- File 20200609-collapse.diff 20200609-collapse.diff added
- File 20200609-series.diff 20200609-series.diff added
r19803 changed ajax behavior and it broke previous patches.
These are fixed patches.