Patch #31327
closed
Update CONTRIBUTING.md
Description
I feel that the sentence "Do not send a pull request to this GitHub repository" in CONTRIBUTING.md (source:tags/4.0.3/CONTRIBUTING.md) is a bit harsh. I want to soften the tone to reduce the psychological hurdle of contributing.
Here is my idea of new CONTRIBUTING.md. Feedbacks welcome.
Files
Updated by Bernhard Rohloff over 5 years ago
You're absolutely right. Your wording sounds much more polite and also gives a sane reason for it.
Updated by Go MAEDA over 5 years ago
Bernhard Rohloff wrote:
You're absolutely right. Your wording sounds much more polite and also gives a sane reason for it.
Thank you for the feedback. I am not good at English, so please don't hesitate to point out any mistakes in grammar or wording.
Updated by Jan from Planio www.plan.io over 5 years ago
- File CONTRIBUTING.md CONTRIBUTING.md added
I am for this change and I've reworded the 2nd sentence a bit. I think we can say that PRs might not even get reviewed at all without being impolite here.
@@ -1,8 +1,8 @@
-Please **open an issue on the [official website]** instead of sending pull-requests.
+Please **open an issue on the [official website]** instead of sending pull requests.
-Since the development of Redmine is conducted on not GitHub but the [official web site] and core developers rarely see the repo on GitHub, it may take a longer time for pull-requests on GitHub to be reviewed.
+Since the development of Redmine is not conducted on GitHub but on the [official web site] and core developers are not monitoring the GitHub repo, pull requests might not get reviewed.
-For more detail about how to contribute, please see the wiki page [Contribute] on the [official website].
+For more detail about how to contribute, please see the wiki page [Contribute] on the [official website].
[official website]: https://www.redmine.org
[Contribute]: https://www.redmine.org/projects/redmine/wiki/ContributeI'm attaching my version. Should we also add Your contributions to Redmine are welcome! to the beginning? :-)
Updated by Go MAEDA over 5 years ago
Jan from Planio www.plan.io wrote:
I am for this change and I've reworded the 2nd sentence a bit.
Thank you for fixing the sentence. It has become much better!
I'm attaching my version. Should we also add
Your contributions to Redmine are welcome!to the beginning? :-)
Do you mean like the following? I like this idea.
Your contributions to Redmine are welcome! Please **open an issue on the [official website]** instead of sending pull requests.
Updated by Jan from Planio www.plan.io over 5 years ago
I think that would be great, yes.
Updated by
Updated by Go MAEDA over 5 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the new CONTRIBUTING.md. Thanks.