Project

General

Profile

Actions

Patch #31356

closed

replace icon-fav with icon-user for 'my projects'

Added by Jens Krämer over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Projects
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Files

0001-feature-my-projects-fav-user-icon.patch (1.59 KB) 0001-feature-my-projects-fav-user-icon.patch Jens Krämer, 2019-05-13 11:06
31356-before@2x.png (38.1 KB) 31356-before@2x.png Go MAEDA, 2019-05-13 11:22
31356-after@2x.png (40.3 KB) 31356-after@2x.png Go MAEDA, 2019-05-13 11:22
0001-swaps-out-the-icon-fav-for-icon-user-on-projects-ind.patch (2.3 KB) 0001-swaps-out-the-icon-fav-for-icon-user-on-projects-ind.patch updated patch that keeps the icon positioning at the end of the project name Jens Krämer, 2019-05-13 13:28

Related issues

Related to Redmine - Feature #31355: Bookmarks and recently used projects for the project jump boxClosedGo MAEDA

Actions
Actions #1

Updated by Jens Krämer over 5 years ago

While working on #31355 we (Planio, that is) found that using the fav icon that is also used for watching things is not really appropriate for designating projects the user is a member of. We'd vote for replacing this with the user icon instead on the All projects list, which is what the attached patch does.

Actions #2

Updated by Go MAEDA over 5 years ago

[Before]

[After]

Actions #3

Updated by Go MAEDA over 5 years ago

  • Related to Feature #31355: Bookmarks and recently used projects for the project jump box added
Actions #4

Updated by Jens Krämer over 5 years ago

updated patch that keeps the icon positioning at the end of the project name

Actions #5

Updated by Go MAEDA over 5 years ago

  • Category set to Projects
  • Target version changed from Candidate for next major release to 4.1.0

I am in favor of this change.

The current "My project" icon "★" is used as a "Watch" icon in other pages. Therefore, it looks as if those are watched projects (some notifications are sent).

Since "My projects" means "the projects I am a member of", I think that using "icon-user" is reasonable.

Setting the target version to 4.1.0.

Actions #6

Updated by Marius BĂLTEANU over 5 years ago

I'm in favour too.

Actions #7

Updated by Go MAEDA over 5 years ago

  • Subject changed from replace icon-fav with icon-user for 'my projects to replace icon-fav with icon-user for 'my projects'
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thanks.

Actions

Also available in: Atom PDF