Patch #31385
Formating toolbar : new color tools
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | UI | |||
| Target version: | Candidate for next major release |
Description
- text color
- background color
RM_31385_formating_toolbar_color_tools_SVN.diff 
(4.3 KB)
bt_bgcolor.png (429 Bytes)
bt_color.png (699 Bytes)
text_color_and_background.png (8.75 KB)
text_color.png (14.8 KB)
RM_31385_formating_toolbar_color_tools_SVN.diff
(6.25 KB)
RM_31385_formating_toolbar_color_tools_SVN.diff
(6.81 KB)
RM_31385_formating_toolbar_color_tools2_SVN.diff
(8.36 KB)
RM_31385_formating_toolbar_color_tools_jstoolbar_SVN.diff
(4.44 KB)
History
#1
Updated by Jérôme BATAILLE over 3 years ago
The correct issue title should : Formating toolbar : new color tools
#2
Updated by Go MAEDA over 3 years ago
- Subject changed from Wiki formating tous : new color tools to Formating toolbar : new color tools
#3
Updated by Jérôme BATAILLE over 3 years ago
- File RM_31385_formating_toolbar_color_tools_SVN.diff added
- File bt_color.png added
- File bt_bgcolor.png added
Here is the patch, and the 2 new images to put in public/images/jstoolbar/
This patch does not manage the case when we want background an text color at the same time.
#4
Updated by Jérôme BATAILLE over 3 years ago
- File text_color.png added
- File text_color_and_background.png added
#5
Updated by Jérôme BATAILLE over 3 years ago
Here is a new patch managing some mixed cases of color / background color.
Detects if selected text already contains a css tag.- If tag contains the css we want, replace the color.
- If not, add the css to the other tags.
#6
Updated by Jérôme BATAILLE over 3 years ago
Fixed previous patch.
Managed more mixed color / background color tags.
@Go thanks to have renamed the issue subject
#7
Updated by Go MAEDA over 3 years ago
The patch seems supports only Textile but Markdown. Since Redmine supports both Textile and Markdown, I think the patch should also support Markdown.
#8
Updated by Jérôme BATAILLE over 3 years ago
Hi, I am going to provide the patch for <span style color="green">Markdown</span>
Now that Textile is OK.
#9
Updated by Jérôme BATAILLE over 3 years ago
Hi, here is a patch to apply after the previous patch.
It includes code refactoring and Markdown support.
For Markdown, html filter must be disabled (C.f. http://www.redmine.org/boards/2/topics/56096?r=57052#message-57052).
One remark about responsive design, the tools icons div has no horizontal scrollbar enabled. Thus some icons on the right can disappear with smaller window size.
#10
Updated by Go MAEDA over 3 years ago
- Target version set to Candidate for next major release
#11
Updated by Jérôme BATAILLE over 3 years ago
Thanks Go to have proposed this for the next major release.
#12
Updated by Dmitry Makurin over 3 years ago
Two latest patches don't work without:
Index: public/javascripts/jstoolbar/jstoolbar.js
===================================================================
--- public/javascripts/jstoolbar/jstoolbar.js (date 1568621686000)
+++ public/javascripts/jstoolbar/jstoolbar.js (date 1568636186385)
@@ -373,12 +373,12 @@
}
if (typeof(fn) == 'function') {
- res = (sel) ? fn.call(this,sel) : fn('');
+ res = (sel) ? fn.call(this,sel,prefix,suffix) : fn('');
} else {
res = (sel) ? sel : '';
}
- subst = prefix + res + suffix;
+ subst = res;
if (typeof(document["selection"]) != "undefined") {
document.selection.createRange().text = subst;
Am I missing something? That change have never been mentioned in any of related patches.
#13
Updated by Jérôme BATAILLE over 3 years ago
Hello, you're right changes to jstoolbar.js were missing.
Here is the full SVN diff for this file.