Patch #31385
open
Formating toolbar : new color tools
Added by Jérôme BATAILLE over 5 years ago. Updated over 5 years ago.
0%
Description
- text color
- background color
Files
Updated by Jérôme BATAILLE over 5 years ago
The correct issue title should : Formating toolbar : new color tools
Updated by Go MAEDA over 5 years ago
- Subject changed from Wiki formating tous : new color tools to Formating toolbar : new color tools
Updated by Jérôme BATAILLE over 5 years ago
- File RM_31385_formating_toolbar_color_tools_SVN.diff RM_31385_formating_toolbar_color_tools_SVN.diff added
- File bt_color.png bt_color.png added
- File bt_bgcolor.png bt_bgcolor.png added
Here is the patch, and the 2 new images to put in public/images/jstoolbar/
This patch does not manage the case when we want background an text color at the same time.
Updated by Jérôme BATAILLE over 5 years ago
- File text_color.png text_color.png added
- File text_color_and_background.png text_color_and_background.png added
Updated by Jérôme BATAILLE over 5 years ago
- File RM_31385_formating_toolbar_color_tools_SVN.diff RM_31385_formating_toolbar_color_tools_SVN.diff added
Here is a new patch managing some mixed cases of color / background color.
Detects if selected text already contains a css tag.- If tag contains the css we want, replace the color.
- If not, add the css to the other tags.
Updated by Jérôme BATAILLE over 5 years ago
- File RM_31385_formating_toolbar_color_tools_SVN.diff RM_31385_formating_toolbar_color_tools_SVN.diff added
Fixed previous patch.
Managed more mixed color / background color tags.
@Go thanks to have renamed the issue subject
Updated by Go MAEDA over 5 years ago
The patch seems supports only Textile but Markdown. Since Redmine supports both Textile and Markdown, I think the patch should also support Markdown.
Updated by Jérôme BATAILLE over 5 years ago
Hi, I am going to provide the patch for <span style color="green">Markdown</span>
Now that Textile is OK.
Updated by Jérôme BATAILLE over 5 years ago
- File RM_31385_formating_toolbar_color_tools2_SVN.diff RM_31385_formating_toolbar_color_tools2_SVN.diff added
Hi, here is a patch to apply after the previous patch.
It includes code refactoring and Markdown support.
For Markdown, html filter must be disabled (C.f. http://www.redmine.org/boards/2/topics/56096?r=57052#message-57052).
One remark about responsive design, the tools icons div has no horizontal scrollbar enabled. Thus some icons on the right can disappear with smaller window size.
Updated by Go MAEDA over 5 years ago
- Target version set to Candidate for next major release
Updated by Jérôme BATAILLE over 5 years ago
Thanks Go to have proposed this for the next major release.
Updated by Dmitry Makurin over 5 years ago
Two latest patches don't work without:
Index: public/javascripts/jstoolbar/jstoolbar.js
===================================================================
--- public/javascripts/jstoolbar/jstoolbar.js (date 1568621686000)
+++ public/javascripts/jstoolbar/jstoolbar.js (date 1568636186385)
@@ -373,12 +373,12 @@
}
if (typeof(fn) == 'function') {
- res = (sel) ? fn.call(this,sel) : fn('');
+ res = (sel) ? fn.call(this,sel,prefix,suffix) : fn('');
} else {
res = (sel) ? sel : '';
}
- subst = prefix + res + suffix;
+ subst = res;
if (typeof(document["selection"]) != "undefined") {
document.selection.createRange().text = subst;
Am I missing something? That change have never been mentioned in any of related patches.
Updated by Jérôme BATAILLE over 5 years ago
- File RM_31385_formating_toolbar_color_tools_jstoolbar_SVN.diff RM_31385_formating_toolbar_color_tools_jstoolbar_SVN.diff added
Hello, you're right changes to jstoolbar.js were missing.
Here is the full SVN diff for this file.