Redmine

The correct issue title should : Formating toolbar : new color tools

The patch seems supports only Textile but Markdown. Since Redmine supports both Textile and Markdown, I think the patch should also support Markdown.

Hi, I am going to provide the patch for <span style color="green">Markdown</span>

Now that Textile is OK.

Thanks Go to have proposed this for the next major release.

Two latest patches don't work without:

Index: public/javascripts/jstoolbar/jstoolbar.js
===================================================================
--- public/javascripts/jstoolbar/jstoolbar.js    (date 1568621686000)
+++ public/javascripts/jstoolbar/jstoolbar.js    (date 1568636186385)
@@ -373,12 +373,12 @@
         }

         if (typeof(fn) == 'function') {
-            res = (sel) ? fn.call(this,sel) : fn('');
+            res = (sel) ? fn.call(this,sel,prefix,suffix) : fn('');
         } else {
             res = (sel) ? sel : '';
         }

-        subst = prefix + res + suffix;
+        subst = res;

         if (typeof(document["selection"]) != "undefined") {
             document.selection.createRange().text = subst;

Am I missing something? That change have never been mentioned in any of related patches.