Patch #31391
closed
Small refactorization of avatar methods
Added by Marius BĂLTEANU over 5 years ago.
Updated over 5 years ago.
Category:
Code cleanup/refactoring
Description
Small refactorization of avatar methods:
- move existing methods from ApplicationHelper to a new helper file (AvatarsHelper)
- change default avatar size from 50 to 24 because most of the avatars are using the size 24
- class 'gravatar' is always added and all custom classes are appended
- added user name as default title for avatar images
- added two new methods:
assignee_avatar and author_avatar
This patch will change 2 existing behaviours:
- in issue#show page, the titles for assignee and author will have the format: Assignee: <user name> and Author: <user name>
- the default title of all avatar is now <user name>
The implementation could be improved more, but it is enough for now.
Any feedback is welcome!
Files
- Target version set to 4.1.0
LGTM. Setting the target version to 4.1.0.
- Blocks Patch #5899: Display user's gravatar when editing profile added
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the patch. Thanks.
- Status changed from Closed to Reopened
IssuesController#show raises "undefined method `html_safe' for nil:NilClass" error if the issue is assigned to a group. We can fix the error by applying the following fix.
Index: app/helpers/avatars_helper.rb
===================================================================
--- app/helpers/avatars_helper.rb (リビジョン 18186)
+++ app/helpers/avatars_helper.rb (作業コピー)
@@ -24,7 +24,7 @@
return '' unless user
options.merge!(:title => l(:field_assigned_to) + ": " + user.name)
- avatar(user, options).html_safe
+ avatar(user, options).to_s.html_safe
end
def author_avatar(user, options={})
@@ -31,7 +31,7 @@
return '' unless user
options.merge!(:title => l(:field_author) + ": " + user.name)
- avatar(user, options).html_safe
+ avatar(user, options).to_s.html_safe
end
# Returns the avatar image tag for the given +user+ if avatars are enabled
- Status changed from Reopened to Closed
Go MAEDA wrote:
IssuesController#show raises "undefined method `html_safe' for nil:NilClass" error if the issue is assigned to a group. We can fix the error by applying the following fix.
[...]
Committed the fix.
Go MAEDA wrote:
Committed the fix.
Thanks! Anyway, I'll take again a look over the changes proposed by just to be sure that I didn't break anything else.
Also available in: Atom
PDF
Updated by 
Updated by