Project

General

Profile

Actions
Copy link

Feature #32436

closed

Add support for grouping by issue on timelog view

Added by Kouhei Sutou over 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Time tracking
Target version:
4.2.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

We can view how many hours we spend for the target issue and its child issues in timelog view (/projects/${PROJECT}/time_entries?set_filter=1&f[]=issue_id&op[issue_id]=~&v[issue_id][]=${ISSUE_ID}).

If we can group by issue, we can confirm how many hours we spend for each issue in the view easily. It's useful to analysis which issue was heavy.

The attached patch implements this feature.

Files

Download all files
timelog-issue-groupable.diff (1.82 KB) timelog-issue-groupable.diff Kouhei Sutou, 2019-11-08 08:42
spent-time-group-by-issue@2x.png (68.5 KB) spent-time-group-by-issue@2x.png Go MAEDA, 2019-11-09 10:47
Actions
Copy link
 #1

Updated by Go MAEDA over 5 years ago

This is a nice improvement. Setting the target version to 4.1.0.

Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 5 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

Actions
Copy link
 #3

Updated by Marius BĂLTEANU over 5 years ago

  • Status changed from Closed to Reopened

A test fails on Postgresql (because of the #32404):


Failure:
TimelogControllerTest#test_index_grouped_by_issue [/builds/redmine-org/redmine/test/functional/timelog_controller_test.rb:1429]:
--- expected
+++ actual
@@ -1 +1 @@
-"Bug #1: Cannot print recipes" 
+"Bug #3: Error 281 when updating a recipe" 

bin/rails test test/functional/timelog_controller_test.rb:1422

Until we fix that issue, I think it is good enough to rewrite the test added in r19063 as following:

index 9c0b958b9..a362e769d 100644
--- a/test/functional/timelog_controller_test.rb
+++ b/test/functional/timelog_controller_test.rb
@@ -1426,10 +1426,6 @@ class TimelogControllerTest < Redmine::ControllerTest
       }
     assert_response :success

-    assert_select 'tr.group span.name' do |elements|
-      target_element = elements[1]
-      assert_equal "Bug #1: Cannot print recipes", target_element.text
-      assert_select target_element, '+ span.count', :text => '2'
-    end
+    assert_select 'tr.group span.name', :text => "Bug #1: Cannot print recipes" 
   end
 end
Actions
Copy link
 #4

Updated by Kouhei Sutou over 5 years ago

Does the following also work on PostgreSQL?

diff --git a/test/functional/timelog_controller_test.rb b/test/functional/timelog_controller_test.rb
index 9c0b958b99..d2f6c94640 100644
--- a/test/functional/timelog_controller_test.rb
+++ b/test/functional/timelog_controller_test.rb
@@ -1426,10 +1426,8 @@ class TimelogControllerTest < Redmine::ControllerTest
       }
     assert_response :success

-    assert_select 'tr.group span.name' do |elements|
-      target_element = elements[1]
-      assert_equal "Bug #1: Cannot print recipes", target_element.text
-      assert_select target_element, '+ span.count', :text => '2'
+    assert_select 'tr.group span.name', :text => 'Bug #1: Cannot print recipes' do
+      assert_select '+ span.count', :text => '2'
     end
   end
 end
Actions
Copy link
 #5

Updated by Marius BĂLTEANU over 5 years ago

Kouhei Sutou wrote:

Does the following also work on PostgreSQL?

[...]

From my point of view, it is not so important to validate the group count number in this case.

Actions
Copy link
 #6

Updated by Kouhei Sutou over 5 years ago

I don't have strong opinion for this. I'm OK without assertion for count.

Actions
Copy link
 #7

Updated by Jean-Philippe Lang over 5 years ago

  • Target version changed from 4.1.0 to 4.2.0
Actions
Copy link
 #8

Updated by Yuichi HARADA over 5 years ago

Kouhei Sutou wrote:

Does the following also work on PostgreSQL?

[...]

TimelogControllerTest passed after applying the #32436-4 patch.

-- Before: trunk(r19089) --

$ RAILS_ENV=test bundle exec rake db:migrate:reset

$ RAILS_ENV=test bundle exec rake test TEST=test/functional/timelog_controller_test.rb
Run options: --seed 27908

# Running:

............................................................................................F

Failure:
TimelogControllerTest#test_index_grouped_by_issue [test/functional/timelog_controller_test.rb:1429]:
--- expected
+++ actual
@@ -1 +1 @@
-"Bug #1: Cannot print recipes" 
+"Bug #3: Error 281 when updating a recipe" 

bin/rails test test/functional/timelog_controller_test.rb:1422

..........

Finished in 19.580212s, 5.2604 runs/s, 16.1387 assertions/s.
103 runs, 316 assertions, 1 failures, 0 errors, 0 skips

-- After: Apply #32436-4 patch --

$ RAILS_ENV=test bundle exec rake db:migrate:reset

$ RAILS_ENV=test bundle exec rake test TEST=test/functional/timelog_controller_test.rb
Run options: --seed 52670

# Running:

.......................................................................................................

Finished in 21.153100s, 4.8693 runs/s, 14.9387 assertions/s.
103 runs, 316 assertions, 0 failures, 0 errors, 0 skips
Actions
Copy link
 #9

Updated by Jean-Philippe Lang over 5 years ago

  • Status changed from Reopened to Closed

Kouhei Sutou wrote:

Does the following also work on PostgreSQL?

Thanks, the assertion is better like this as it doesn't rely on the display order. It's committed.

Actions
Copy link
 #10

Updated by Go MAEDA over 4 years ago

  • Tracker changed from Patch to Feature
  • Resolution set to Fixed
Actions
Copy link

Also available in: Atom PDF