Project

General

Profile

Actions
Copy link

Defect #32812

closed

Clicking on a parent object in gantt wrongly collapses objects at the same level

Added by Yuichi HARADA almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Gantt
Target version:
4.1.1
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

We expect that when a parent ticket is collapsed, only tickets of the child hierarchy and below will be collapsed.
Actually, when the parent ticket (#9) is collapsed, "tickets of the child hierarchy and below (#68,#69,#70)" and " ticket in the same hierarchy (#10)" are collapsed.

Reproduce:

Expect: Actual:

Files

Download all files
reproduce.png (145 KB) reproduce.png Yuichi HARADA, 2020-01-15 03:55
expect.png (124 KB) expect.png Yuichi HARADA, 2020-01-15 03:56
actual.png (116 KB) actual.png Yuichi HARADA, 2020-01-15 03:57

Related issues

Related to Redmine - Feature #6417: Allow collapse/expand in gantt chartClosedGo MAEDA2010-09-16

Actions
Actions
Copy link
 #1

Updated by Yuichi HARADA almost 5 years ago

The cause is that the start position (subject_left) did not include the width of the folding icon.
Solved by the following patch (Firefox, Chrome, Safari, IE11, Edge confirmed).

diff --git a/public/javascripts/gantt.js b/public/javascripts/gantt.js
index ebaaa2b46..efda080ee 100644
--- a/public/javascripts/gantt.js
+++ b/public/javascripts/gantt.js
@@ -231,8 +231,9 @@ function resizableSubjectColumn(){
 }

 ganttEntryClick = function(e){
-  var subject = $(e.target.parentElement);
-  var subject_left = parseInt(subject.css('left'));
+  var icon_expander = e.target;
+  var subject = $(icon_expander.parentElement);
+  var subject_left = parseInt(subject.css('left')) + parseInt(icon_expander.offsetWidth);
   var target_shown = null;
   var target_top = 0;
   var total_height = 0;
Actions
Copy link
 #2

Updated by Go MAEDA almost 5 years ago

  • Status changed from New to Confirmed
  • Target version set to 4.1.1

Setting the target version to 4.1.1.

Actions
Copy link
 #3

Updated by Go MAEDA almost 5 years ago

  • Related to Feature #6417: Allow collapse/expand in gantt chart added
Actions
Copy link
 #4

Updated by Go MAEDA almost 5 years ago

  • Subject changed from Gantt: Folding parent ticket collapses all subsequent tickets to Clicking on a parent object in gantt wrongly collapses objects at the same level
  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

Actions
Copy link

Also available in: Atom PDF