Project

General

Profile

Actions
Copy link

Defect #32912

closed

Rails 6: update no longer bypass optimistic locking

Added by Pavel Rosický almost 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Rails support
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

fixes test failures

 ActiveRecord::StaleObjectError: Attempted to update a stale object: Issue.
    app/models/issue.rb:214:in `create_or_update'

https://github.com/rails/rails/commit/c14e1611e94a7461f219b4349e926592e65241ad

Files

stale.patch (3.19 KB) stale.patch Pavel Rosický, 2020-01-29 00:35

Related issues

Related to Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadingClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Pavel Rosický almost 5 years ago

I'm not sure about test_copy_should_not_copy_subtasks_twice_when_saving_twice which was introduced in https://github.com/redmine/redmine/commit/5003927f13f54850ca9eeac48e353df5e4e325a1

it should be probably refactored in order to reflect the new behaviour or confirm if it's still valid

Actions
Copy link
 #2

Updated by Marius BĂLTEANU almost 5 years ago

  • Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added
Actions
Copy link
 #3

Updated by Go MAEDA over 4 years ago

  • Category set to Rails support
Actions
Copy link
 #4

Updated by Marius BĂLTEANU over 3 years ago

  • Tracker changed from Patch to Defect
Actions
Copy link
 #5

Updated by Go MAEDA over 3 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed as a part of #29914.

Actions
Copy link

Also available in: Atom PDF