Project

General

Profile

Actions

Defect #33083

closed

Projects filter "Subproject of" does not work when the given value is "My projects" or "My bookmarks"

Added by Mizuki ISHIKAWA about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Projects
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Reproduction steps:
  • Use PostgreSQL
  • View projects/index
  • Add "Subproject of" filter
  • Set the operator of the "Subproject of" filter to "is" or "is not"
  • Set the value of the "Subproject of" filter to << my projects >> or << my bookmarks >>
  • Apply => An exception occurs

Error message:

ActiveRecord::StatementInvalid (PG::InvalidTextRepresentation: ERROR:  invalid input syntax for integer: "mine" 
LINE 1: ...rojects.status <> 9) AND ((projects.parent_id IN ('mine'))) ...
                                                             ^
: SELECT "projects".* FROM "projects" WHERE (projects.status <> 9) AND ((projects.parent_id IN ('mine'))) ORDER BY projects.lft ASC):

app/controllers/projects_controller.rb:57:in `block (2 levels) in index'
app/controllers/projects_controller.rb:53:in `index'
lib/redmine/sudo_mode.rb:64:in `sudo_mode'

Executing the SELECT statement without converting << my projects >>('mine') and << my bookmarks >>('bookmarks') to actual ids is the cause of this problem.


Files

projects.png (37.4 KB) projects.png Mizuki ISHIKAWA, 2020-03-03 08:57
fix-33083.patch (2.03 KB) fix-33083.patch Mizuki ISHIKAWA, 2020-03-03 09:00

Related issues

Related to Redmine - Feature #29482: Query system for Projects pageClosedJean-Philippe Lang

Actions
Actions #1

Updated by Mizuki ISHIKAWA about 4 years ago

I have attached a patch to fix this problem.

Actions #2

Updated by Go MAEDA about 4 years ago

Actions #3

Updated by Go MAEDA about 4 years ago

  • Status changed from New to Confirmed
  • Affected version set to 4.1.0
Actions #4

Updated by Marius BÄ‚LTEANU about 4 years ago

  • Target version set to 4.1.1

Looks good to me.

Actions #5

Updated by Go MAEDA about 4 years ago

  • Subject changed from Filtering the parent_id field in Project by "My projects" or "My bookmarks" raises an exception to Projects filter "Subproject of" does not work when the given value is "My projects" or "My bookmarks"
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you for catching and fixing the issue.

Actions #6

Updated by Go MAEDA about 4 years ago

  • Status changed from Resolved to Closed
  • Assignee deleted (Go MAEDA)
  • Resolution deleted (Fixed)
Actions #7

Updated by Go MAEDA about 4 years ago

  • Assignee set to Go MAEDA
  • Resolution set to Fixed
Actions

Also available in: Atom PDF