Redmine

+1
It's a great idea!
Query system is necessary for users who are members of many projects.
And I think the table is more beautiful than the current layout.

I hope that this change will enter the trunk as soon as possible.

I don't know.

I'd say most users of most installations do not have access to that many projects at the same time to justify the full filtering capabilities here.

While I can see the appeal in just reusing the Issues / Time entries list and filter UI, I don't think that just because we already have that, it is the best solution for this page. Agreed, the current multi-column layout has issues to the point that we stuck to the single-column display at Planio, but I'd vote for fixing that instead of turning the projects page into just another "dull" tabular listing.

This page is one of several possible entry points for users to drill down deeper and as such, a more visually appealing layout would be better imho. If there really is need for search / filtering (is there? you can always use Ctrl-F as long as no pagination is involved), a single search slot searching over titles, identifiers and descriptions and limiting the list of projects on the fly would be enough.

As an admin who needs to manage projects instead of just looking at them and finding / selecting one, you always have the full list at /admin/projects.

HOW I setup the Patch ?

RUN patch -p1 < the-patch-file.patch.project did not work out .
shows:
Internal error
An error occurred on the page you were trying to access.
If you continue to experience problems please contact your Redmine administrator for assistance.

If you are the Redmine administrator, check your log files for details about the error.

Hunk #2 FAILED at 250.
1 out of 2 hunks FAILED -- saving rejects to file public/stylesheets/application.css.rej

I aggree with Jens Krämer on the fact that a table can't be the default way to show an overview of the projects landscape, as it's hard for the user to orientate himself within the project structure. That said, it could be indeed a very useful additional view and a great way for project managers to get a quick status report over their projects.

And yes, the current implementation of the projects view is horrible! Perhaps we can start a discussion about ideas for a better solution on the forums or in the discord channel..!?

zhangzhi liao wrote:

HOW I setup the Patch ?

Please use forum to request help.

I run
sudo patch p0 < 0001-Queries-for-Projects.patch
It's show
Hunk #2 FAILED at 250.
1 out of 2 hunks FAILED - saving rejects to file public/stylesheets/application.css.rej.

Jens Krämer wrote:

I don't know.

Hi Jens,

First of all, thanks for your feedback. Please find my thoughts below.

I'd say most users of most installations do not have access to that many projects at the same time to justify the full filtering capabilities here.

In our instance (which is a single instance and not a Saas like), we have more than 200 active projects and our non admin internal users have access in average to almost 30 projects (including the public ones), but they are actively involved only in 4 - 8 projects. This is my case also, even if I'm an admin user, I work daily only with 4 projects. I thought that is only our problem, but I looked in the tickets and the number of Redmine.org users that requested in the past a better project list, filter capabilities and custom queries is quite big. I've related to this ticket only 7 tickets, but there are a lot more and I'll go through all of them these days.

While I can see the appeal in just reusing the Issues / Time entries list and filter UI, I don't think that just because we already have that, it is the best solution for this page. Agreed, the current multi-column layout has issues to the point that we stuck to the single-column display at Planio, but I'd vote for fixing that instead of turning the projects page into just another "dull" tabular listing.

I didn't work on this just because we already have that, I really think that once we have the query system in place for the projects list, we can develop some nice features, including a multi-column layout. When we started internally the discussions regarding the Projects page, we agreed that first we need the possibility to filter the projects and right after that, an alternative view (we've already started work on some screens using a masonry layout) because neither of us think that the tabular listing is the best solution. I'll post the screens when they are ready, but until then, please feel free to contribute if you have a proposal.

This page is one of several possible entry points for users to drill down deeper and as such, a more visually appealing layout would be better imho. If there really is need for search / filtering (is there? you can always use Ctrl-F as long as no pagination is involved), a single search slot searching over titles, identifiers and descriptions and limiting the list of projects on the fly would be enough.

I can tell you that it becomes annoying to use multiple times per day the CTRL + F or the quick jump box (both combination requires some extra clicks/steps). Also, I consider the browser buttons non user friendly for users (this is why I worked on #8888).

As an admin who needs to manage projects instead of just looking at them and finding / selecting one, you always have the full list at /admin/projects.

As admin, we need additional columns, filters capabilities and informations that the current list do not provide, please see two examples: #13696, #23954.

In conclusion, I'm not saying that my patch is perfect or the best solution, I'm just saying that is a good starting point (and a must IMHO) to build a nice and useful projects list.

I really want use that Patch,but did not works out .

Environment:
Redmine version 3.4.6.stable
Ruby version 2.3.7-p456 (2018-03-28) [x86_64-linux]
Rails version 4.2.8
Environment production
Database adapter Mysql2
SCM:
Subversion 1.10.0
Git 2.17.1
Filesystem
Redmine plugins:
no plugin installed

zhangzhi liao wrote:

I really want use that Patch,but did not works out .

Environment:
Redmine version 3.4.6.stable
Ruby version 2.3.7-p456 (2018-03-28) [x86_64-linux]
Rails version 4.2.8
Environment production
Database adapter Mysql2
SCM:
Subversion 1.10.0
Git 2.17.1
Filesystem
Redmine plugins:
no plugin installed

The patches are made against Redmine trunk version (future 4.0.0 Release) and not current Redmine 3.4.6 version. Please again, use Forums to request help. Here we should discuss about the feature implementation in the Redmine core.

+1

This is a very useful feature.
Users, who have access to few projects don’t care the view of Project window.
I have usually a lot of active projects and it would be much better to use a table view.

• Spent time
• Estimated time
• Custom fields (numbers only)

These sums are implemented in an issues view.

I think Description should be left aligned (because of Wiki formatting of this field).

I just discovered this issue and would like to emphasize that these are very useful features - thank you very much for implementing them.

In addition we may be able to help with testing - just let us know if you think that makes sense.

Finally, if it is not too complicated, we may consider doing a 3.x backport or 3.x plugin for those features since we would love to use it asap.

Jens Krämer wrote:

While I can see the appeal in just reusing the Issues / Time entries list and filter UI, I don't think that just because we already have that, it is the best solution for this page. Agreed, the current multi-column layout has issues to the point that we stuck to the single-column display at Planio, but I'd vote for fixing that instead of turning the projects page into just another "dull" tabular listing.

Jens, I've added to #29951 two proposals for the projects page.

This is a super useful feature. Thanks for making this patch. I did not quite get if it makes possible filtering by custom fields. Hope this feature is available.

+1
Thanks for good patch :)

1. Pagination applies also for the "Board" view and I'm not sure if is ok or we should not limit the returned results (as is right now).

I think ok.

2. If the default view (Board or List) should be configurable in the Administration page.

I think we should config it.

BTW default_sort_criteria in project_query.rb is correct?
A parent-child relation of projects is not good display on default list view.
I think following is better.

  def default_sort_criteria
-    [['lft', 'desc']]
+   [['parent_id', 'desc']]
  end

I hope this will be helpful to you.

Tatsuya Saito wrote:

2. If the default view (Board or List) should be configurable in the Administration page.

I think we should config it.

I'll do it in a next patch.

BTW default_sort_criteria in project_query.rb is correct?
A parent-child relation of projects is not good display on default list view.
I think following is better.

I preferred to keep the current sort.

I hope this will be helpful to you.

Thanks. Any feedback is helpful.

+1 please add this feature

Can this patch please include the ability to filter projects based on their custom fields?

I'm working on updating the patch series to apply cleanly on the current trunk.

+1

This looks great, current default project page is useless. We use a plugin to deal somehow with big number of projects we have.

The only missing function would be ability to filter by custom fields and add/mark favorite projects.

According to the current trunk you should probably change 'my project' icon

Index: app/helpers/projects_queries_helper.rb
===================================================================
--- app/helpers/projects_queries_helper.rb    (date 1568619252000)
+++ app/helpers/projects_queries_helper.rb    (date 1568619564203)
@@ -23,7 +23,7 @@
     if item.is_a?(Project)
       case column.name
       when :name
-        link_to_project(item) + (content_tag('span', '', :class => 'icon icon-fav my-project', :title => l(:label_my_projects)) if User.current.member_of?(item))
+        link_to_project(item) + (content_tag('span', '', :class => 'icon icon-user my-project', :title => l(:label_my_projects)) if User.current.member_of?(item))
       when :short_description
         item.description? ? content_tag('div', textilizable(item, :short_description), :class => "wiki") : ''
       when :homepage

+1

Yuuki NARA wrote:

+1

+1 because Yuuki NARA +1ed ;D

Go MAEDA wrote:

Marius BALTEANU wrote:

Please commit the below change in order to prevent a random test failure:

Committed in r18787.

Thanks!

Bernhard Rohloff wrote:

There is a small flaw in the query save form. The labels on the Display results section are overlapping each other.

Could you tell me how to reproduce the problem? I cannot observe the overlapped labels with Firefox and Chrome.

Go MAEDA wrote:

Bernhard Rohloff wrote:

There is a small flaw in the query save form. The labels on the Display results section are overlapping each other.

Could you tell me how to reproduce the problem? I cannot observe the overlapped labels with Firefox and Chrome.

I have them in both Firefox and Chrome on a Fedora 30 and an Ubuntu 18.04 install. I just visit the projects page, click on save and there it is. I've tested Marius' patches and they are solving the issue.

Zbigniew Nowacki wrote:

+1

This is a very useful feature.

I second that!!

I'm on the same page with Marco Descher, Fabian Schuttenberg, Antonio McDeal, Yuuki Nara and all of the other contributors who are clapping it up.

Marius, that will be such a great enhancement, although I'm curious to find out more about Vincent Robert's hint about https://github.com/jbbarth/redmine_better_crossprojects

QueryTest#test_filter_my_bookmarks has failed.

$ RAILS_ENV=test bundle exec rake db:migrate:reset

$ RAILS_ENV=test bundle exec rake test TEST=test/unit/query_test.rb
Run options: --seed 55582

# Running:

................................................................................................................................................................................F

Failure:
QueryTest#test_filter_my_bookmarks [test/unit/query_test.rb:930]:
"bookmarks" not found in "["mine", "1", "5", "6", "3", "4", "2"]" 

bin/rails test test/unit/query_test.rb:925

.............................................

Finished in 8.093826s, 27.4283 runs/s, 76.6016 assertions/s.
222 runs, 620 assertions, 1 failures, 0 errors, 0 skips

I think that because the fixture is not enough.

diff --git a/test/unit/query_test.rb b/test/unit/query_test.rb
index 0fa9cf510..3ccfc753a 100644
--- a/test/unit/query_test.rb
+++ b/test/unit/query_test.rb
@@ -22,7 +22,7 @@ require File.expand_path('../../test_helper', __FILE__)
 class QueryTest < ActiveSupport::TestCase
   include Redmine::I18n

-  fixtures :projects, :enabled_modules, :users, :members,
+  fixtures :projects, :enabled_modules, :users, :user_preferences, :members,
            :member_roles, :roles, :trackers, :issue_statuses,
            :issue_categories, :enumerations, :issues,
            :watchers, :custom_fields, :custom_values, :versions,

Yuichi HARADA wrote:

QueryTest#test_filter_my_bookmarks has failed.

Thank you. Committed the patch in r18881.

Related #32818.

Related #33490.

How to make projects and issues filters hidden by default?
Can't find configure options for this.
Thanks.