Project

General

Profile

Actions

Defect #33085

closed

Unable to update the values of a custom field for enumerations when multiple values option is enabled

Added by Thomas Löber almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Custom fields
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Hi,

When I add a custom field to an enumeration and the custom field has the "Multiple values" option set, it is not possible to change the custom value when editing the enumeration.

This is because with multiple values the POST parameter is an array, but that is not permitted in the EnumerationsController.

Here is a patch to fix this issue:

   def enumeration_params
     # can't require enumeration on #new action
-    cf_ids = @enumeration.available_custom_fields.map{|c| c.id.to_s}
+    cf_ids = @enumeration.available_custom_fields.map{|c| c.multiple? ? {c.id.to_s => []} : c.id.to_s}
     params.permit(:enumeration => [:name, :active, :is_default, :position, :custom_field_values => cf_ids])[:enumeration]
   end
 end

Best regards,
Thomas


Files

Screenshot_2020-03-08.png (31.6 KB) Screenshot_2020-03-08.png Go MAEDA, 2020-03-08 00:04
add_test.patch (1.18 KB) add_test.patch Mizuki ISHIKAWA, 2020-03-09 06:40
Actions #1

Updated by Go MAEDA almost 5 years ago

I have confirmed that values for a custom field of time tracking activities cannot be saved if "Multiple values" option is enabled.

Actions #2

Updated by Mizuki ISHIKAWA almost 5 years ago

Thomas Löber wrote:

Here is a patch to fix this issue:

[...]

I have confirmed that the code you wrote in descriptipn solves this problem.
To permit an array value of strong_parameters, it is necessary to set an empty array, so {c.id.to_s => []} is set when c.multiple? is true.

The attached patch adds a test to the code written by Thomas Löber.

Actions #3

Updated by Go MAEDA almost 5 years ago

  • Target version set to Candidate for next minor release
Actions #4

Updated by Go MAEDA almost 5 years ago

  • Target version changed from Candidate for next minor release to 4.0.7

Setting the target version to 4.0.7.

Actions #5

Updated by Go MAEDA almost 5 years ago

  • Subject changed from Cannot use custom fields with multiple values in enumerations to Unable to update the values of a custom field for enumerations when multiple values option is enabled
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patches. Thank you for providing the fix.

Actions #6

Updated by Go MAEDA almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF