Patch #33337: Clean-up workflows controller - Redmine

Actions

Copy link

Patch #33337

closed

Clean-up workflows controller

Added by Vincent Robert over 4 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Code cleanup/refactoring

Target version:

5.0.0

Start date:

Due date:

% Done:

Estimated time:

Description

Hello

Here is a patch which aims to refactor the WorkflowsController.
The patch does not change the behavior of the application, but use smaller methods and clearer code. The routes are also updated.

My goal was to use a specific action for each route, and do not use a same method for different purposes (so avoid checking if the request-method is "post" inside actions).

Hope this may help.

Files

Download all files

cleanup_workflows_controller.diff (17.1 KB) cleanup_workflows_controller.diff		Vincent Robert, 2020-04-21 21:10
0002-Fix-route-name.patch (868 Bytes) 0002-Fix-route-name.patch		Marius BĂLTEANU, 2021-04-04 13:14
0001-Clean-up-workflows-controller.patch (17.4 KB) 0001-Clean-up-workflows-controller.patch		Marius BĂLTEANU, 2021-04-04 13:14

Actions

Copy link

Updated by Marius BĂLTEANU almost 4 years ago

Assignee set to Marius BĂLTEANU

Actions

Copy link

Updated by Marius BĂLTEANU almost 4 years ago

File 0001-Clean-up-workflows-controller.patch added
File 0002-Fix-route-name.patch added
Target version set to Candidate for next major release

Thanks Vincent for the patch, I tried it yesterday and it looks great from my point of view.

I'm attaching a rebased version of the initial patch and a second patch that fixes to route name (workflows_permissions_path should be permissions_workflows_path). All the tests pass (https://gitlab.com/redmine-org/redmine/-/commit/4ef4ea5047323756a3241eea660e11a383ea7711) with both patches.

I'm going to review the tests in the following days.

Actions

Copy link