Redmine

Looks good to me.

My patch has problems with column sort order.

But I found the real problem now. It is a missing condition to project_id for Enumeration. I am working on a new patch to fix this problem. Please do not commit the current patch.

Alexander Meindl wrote:

My patch has problems with column sort order.

But I found the real problem now. It is a missing condition to project_id for Enumeration. I am working on a new patch to fix this problem. Please do not commit the current patch.

Nice feature, but we should have tests for this change.

on the ther hand (in regard to #37962) this patch helped a lot under Redmine 4.2.8 (mysql 8):
time for time entries queries was reduced approx by 40% for me.
thank you!

We have hundreds of thousands of time entries and redmine became almost unusable recently, this patch made a huge difference to us. It would be great if it can be pushed into an upcoming release.

I have a problem with the v5 patch.
If you move an issue to another project, the project_id no longer matches the request and is ignored when displaying the numbers.

An example:
Issue 2982 belonged to project with ID = 8 when the time entry 34446 was created and then was moved in another project ID = 17

MariaDB [redmine_import]> select te.*,projects.id,enumerations.id,enumerations.project_id,enumerations.type,users.id,users.type,projects.id FROM time_entries AS te       INNER JOIN `projects` ON `projects`.`id` = te.project_id     INNER JOIN enumerations ON enumerations.id = te.activity_id AND enumerations.type = 'TimeEntryActivity'          INNER JOIN users ON users.id = te.user_id AND users.type IN ('User', 'AnonymousUser')      WHERE te.id=34446;
+-------+------------+-----------+---------+----------+-------+------------------------------------+-------------+------------+-------+--------+-------+---------------------+---------------------+---------+------+----+-----+------------+-------------------+----+------+----+
| id    | project_id | author_id | user_id | issue_id | hours | comments                           | activity_id | spent_on   | tyear | tmonth | tweek | created_on          | updated_on          | rate_id | cost | id | id  | project_id | type              | id | type | id |
+-------+------------+-----------+---------+----------+-------+------------------------------------+-------------+------------+-------+--------+-------+---------------------+---------------------+---------+------+----+-----+------------+-------------------+----+------+----+
| 34446 |         17 |        12 |      12 |     2982 |     4 | Fix alma container issue for devel |         172 | 2021-10-04 |  2021 |     10 |    40 | 2021-10-05 07:59:26 | 2021-10-05 07:59:26 |    NULL | NULL | 17 | 172 |          8 | TimeEntryActivity | 12 | User | 17 |
+-------+------------+-----------+---------+----------+-------+------------------------------------+-------------+------------+-------+--------+-------+---------------------+---------------------+---------+------+----+-----+------------+-------------------+----+------+----+
1 row in set (0.001 sec)

So the DB queries was KO and doesn't display the good numbers, for an hotfix we just removed

def base_result_scope
  base_scope.joins(:activity, :user)
            .includes(:activity)
            .left_join_issue
          # XXX - remove to let time entry report working fine
          # .where(activity_scope_sql)
end

Hello There,
We are facing the issue while loading global spent time. Can the above mentioned patches help us to mitgate our issue. Following are the details of our Redmine Environment:

Environment:
Redmine version 5.1.2.stable
Ruby version 3.2.4-p170 (2024-04-23) [x86_64-linux]
Rails version 6.1.7.7
Environment production
Database adapter Mysql2
Mailer queue ActiveJob::QueueAdapters::SidekiqAdapter
Mailer delivery smtp
Redmine settings:
Redmine theme Zenmine-510 (includes JavaScript)
SCM:
Subversion 1.14.2
Mercurial 6.3.2
Bazaar 3.3.2
Git 2.39.2
Filesystem
Redmine plugins:
redmine_agile 1.6.9
redmine_budgets 1.0.5
redmine_checklists 3.1.23
redmine_contacts 4.4.1
redmine_contacts_helpdesk 4.2.2
redmine_contacts_invoices 4.2.9
redmine_reporter 2.0.4

We have tried installing the time_query_performace_v5.patch but things don't seem to work. Pls guide us on the same to resolve this issue.

Hello there, could anyone pls provide any insights on this.