Project

General

Profile

Actions
Copy link

Patch #33437

closed

Add missing icon class to items with icon-checked class in the context menu

Added by Mizuki ISHIKAWA over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Issues
Target version:
4.2.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Neither .icon class nor .icon-only class exists in context menu link with green check icon.
It looks fine, but inconsistent compared to other icon links.

There is a problem when changing the icon style depending on the theme, so please fix it.


diff --git a/app/helpers/context_menus_helper.rb b/app/helpers/context_menus_helper.rb
index db71abe31..d545f3c51 100644
--- a/app/helpers/context_menus_helper.rb
+++ b/app/helpers/context_menus_helper.rb
@@ -21,7 +21,7 @@ module ContextMenusHelper
   def context_menu_link(name, url, options={})
     options[:class] ||= ''
     if options.delete(:selected)
-      options[:class] += ' icon-checked disabled'
+      options[:class] += ' icon icon-checked disabled'
       options[:disabled] = true
     end
     if options.delete(:disabled)

Files

ScreenShot.png (163 KB) ScreenShot.png Mizuki ISHIKAWA, 2020-05-13 07:32

Related issues

Related to Redmine - Patch #28605: Add the missing icon class to the items with icons from the contextual menuClosedGo MAEDA

Actions
Actions
Copy link

Also available in: Atom PDF