Project

General

Profile

Actions

Defect #33562

closed

Some tests in ApplicationHelperTest are declared as private

Added by Go MAEDA almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The attached patch fixes that the following two test methods are never executed.

  • test_export_csv_encoding_select_tag_should_return_nil_when_general_csv_encoding_is_UTF8
  • test_export_csv_encoding_select_tag_should_have_two_option_when_general_csv_encoding_is_not_UTF8

This is because a private keyword (source:tags/4.1.1/test/helpers/application_helper_test.rb#L1891) is placed before those two methods in r17490.


Files


Related issues

Related to Redmine - Defect #31929: MarkdownFormatterTest#test_should_support_underlined_text is declared as privateClosedGo MAEDA

Actions
Actions

Also available in: Atom PDF