Defect #33563
File selection buttons are not fully displayed with Google Chrome in some language
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | UI | |||
| Target version: | 4.1.2 | |||
| Resolution: | Fixed | Affected version: | 4.1.0 |
Description
The bottom part of file upload buttons is cropped if you use the latest version of Google Chrome in some language mode such as Japanese and Chinese. Attached a patch that fixes the issue.
Current:
Look at the "选择文件" (Choose Files) button. The bottom border is not displayed.
After applying the patch:
fix-chrome-file-button.patch 
(737 Bytes)
chrome-zh-before.png (26.8 KB)
chrome-zh-after.png (27.1 KB)
Related issues
Associated revisions
File selection buttons are not fully displayed with Google Chrome in some language (#33563).
Patch by Go MAEDA.
File selection buttons are not fully displayed with Google Chrome in some language (#33563).
Patch by Go MAEDA.
History
#1
Updated by Go MAEDA about 2 years ago
- Target version set to Candidate for next minor release
#2
Updated by Go MAEDA about 2 years ago
- Target version changed from Candidate for next minor release to 4.1.2
- Affected version set to 4.1.0
Setting the target version to 4.1.2.
#3
Updated by Go MAEDA about 2 years ago
- Subject changed from Google Chrome in some language mode don't fully display file selection buttons to File selection buttons are not fully displayed with Google Chrome in some language
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch.
#4
Updated by Go MAEDA almost 2 years ago
- Related to Defect #33723: File name is displayed over the clip icon in new/edit forms added
#5
Updated by Go MAEDA almost 2 years ago
- Status changed from Closed to Reopened
It should be reverted to fix #33723 and the following patch should be committed instead. See #33723#note-8 for the detail.
diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index 891faf69a..a5fa24da5 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -479,7 +479,7 @@ select {
background-position: calc(100% - 7px) 50%;
padding-right: 20px;
}
-input[type="file"] {border: 0; padding-left: 0; padding-right: 0; background-color: initial; }
+input[type="file"] {border: 0; padding-left: 0; padding-right: 0; height: initial; background-color: initial; }
input[type="submit"], button[type="submit"] {
-webkit-appearance: button;
cursor: pointer;
#6
Updated by Go MAEDA almost 2 years ago
- Status changed from Reopened to Resolved
Go MAEDA wrote:
It should be reverted to fix #33723 and the following patch should be committed instead. See #33723#note-8 for the detail.
[...]
Committed the fix in r20031.
#7
Updated by Go MAEDA almost 2 years ago
- Status changed from Resolved to Closed
#8
Updated by Bernhard Rohloff over 1 year ago
- Related to Patch #34650: Button browse fix added
#9
Updated by Bernhard Rohloff over 1 year ago
- Related to deleted (Patch #34650: Button browse fix)
#10
Updated by Bernhard Rohloff over 1 year ago
- Duplicated by Patch #34650: Button browse fix added