Project

General

Profile

Actions

Defect #33563

closed

File selection buttons are not fully displayed with Google Chrome in some language

Added by Go MAEDA almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The bottom part of file upload buttons is cropped if you use the latest version of Google Chrome in some language mode such as Japanese and Chinese. Attached a patch that fixes the issue.

Current:
Look at the "选择文件" (Choose Files) button. The bottom border is not displayed.

After applying the patch:


Files

fix-chrome-file-button.patch (737 Bytes) fix-chrome-file-button.patch Go MAEDA, 2020-06-06 10:19
chrome-zh-before.png (26.8 KB) chrome-zh-before.png Go MAEDA, 2020-06-06 10:30
chrome-zh-after.png (27.1 KB) chrome-zh-after.png Go MAEDA, 2020-06-06 10:30

Related issues

Related to Redmine - Defect #33723: File name is displayed over the clip icon in new/edit formsClosed

Actions
Has duplicate Redmine - Patch #34650: Button browse fixClosed

Actions
Actions #1

Updated by Go MAEDA almost 4 years ago

  • Target version set to Candidate for next minor release
Actions #2

Updated by Go MAEDA almost 4 years ago

  • Target version changed from Candidate for next minor release to 4.1.2
  • Affected version set to 4.1.0

Setting the target version to 4.1.2.

Actions #3

Updated by Go MAEDA almost 4 years ago

  • Subject changed from Google Chrome in some language mode don't fully display file selection buttons to File selection buttons are not fully displayed with Google Chrome in some language
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Actions #4

Updated by Go MAEDA over 3 years ago

  • Related to Defect #33723: File name is displayed over the clip icon in new/edit forms added
Actions #5

Updated by Go MAEDA over 3 years ago

  • Status changed from Closed to Reopened

r19815 caused issue #33723.

It should be reverted to fix #33723 and the following patch should be committed instead. See #33723#note-8 for the detail.

diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index 891faf69a..a5fa24da5 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -479,7 +479,7 @@ select {
   background-position: calc(100% - 7px) 50%;
   padding-right: 20px;
 }
-input[type="file"] {border: 0; padding-left: 0; padding-right: 0; background-color: initial; }
+input[type="file"] {border: 0; padding-left: 0; padding-right: 0; height: initial; background-color: initial; }
 input[type="submit"], button[type="submit"] {
   -webkit-appearance: button;
   cursor: pointer;
Actions #6

Updated by Go MAEDA over 3 years ago

  • Status changed from Reopened to Resolved

Go MAEDA wrote:

r19815 caused issue #33723.

It should be reverted to fix #33723 and the following patch should be committed instead. See #33723#note-8 for the detail.

[...]

Committed the fix in r20031.

Actions #7

Updated by Go MAEDA over 3 years ago

  • Status changed from Resolved to Closed
Actions #8

Updated by Bernhard Rohloff about 3 years ago

Actions #9

Updated by Bernhard Rohloff about 3 years ago

Actions #10

Updated by Bernhard Rohloff about 3 years ago

Actions

Also available in: Atom PDF