Project

General

Profile

Actions

Feature #34417

closed

Require explicit confirmation when deleting a user or a project

Added by Jens Krämer almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

It happens quite often at Planio that we have to support users who accidentally deleted something. Often, a Javascript alert box is simply dismissed by the user without actually grasping it's message, leading to unintended consequences. Especially in the case of deleted user accounts, a lot of information is lost and hard to restore from a backup.

The first patch in this issue introduces an explicit confirmation page (similar to when deleting a project) which requires to enter the login of the user to be deleted in order to confirm the deletion. It also suggests locking the user as a safer option instead and offers a button to do so.

The second patch changes the project deletion page to require the user to enter the identifier of the project to be deleted, instead of just ticking a checkbox, just to make it a bit harder to delete the wrong project by accident.


Files


Related issues

Related to Redmine - Feature #33071: Prevent accidental deletion of contents with sudo modeReopenedGo MAEDA

Actions
Related to Redmine - Patch #35373: Improve project deletion warning textNew

Actions
Actions #2

Updated by Marius BĂLTEANU almost 4 years ago

  • Subject changed from require explicit confirmation when deleting a user to Require explicit confirmation when deleting a user or a project
  • Target version set to Candidate for next major release

Very nice addition and it works well from my tests.

I've added the patches to CI, if all the tests pass, I think we can deliver this in 4.2.0 and use this implementation to improve other object deletion (like #33071).

Actions #3

Updated by Marius BĂLTEANU almost 4 years ago

  • Related to Feature #33071: Prevent accidental deletion of contents with sudo mode added
Actions #4

Updated by Marius BĂLTEANU almost 4 years ago

  • Target version changed from Candidate for next major release to 4.2.0

Tests pass https://gitlab.com/redmine-org/redmine/-/pipelines/227153244 (except system tests, but there are other issues there).

Actions #5

Updated by Go MAEDA almost 4 years ago

It is a great improvement. I think there is no reason not to deliver this new feature in Redmine 4.2.0.

Actions #6

Updated by Go MAEDA almost 4 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patches. Thank you for your contribution.

Actions #7

Updated by Go MAEDA over 3 years ago

  • Tracker changed from Patch to Feature
  • Resolution set to Fixed
Actions #8

Updated by Go MAEDA over 3 years ago

  • Related to Patch #35373: Improve project deletion warning text added
Actions

Also available in: Atom PDF