Patch #34494

Rename the save, edit and delete buttons on the query form

Added by Mizuki ISHIKAWA 6 months ago. Updated 3 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:5.0.0

Description

It's hard to tell that the subject of the Save, Edit and Delete buttons on the Query form is a custom query.
How about changing it as follows?

  • Save => Save custom query
  • Edit => Edit custom query
  • Delete => Delete custom query


save_after_change.png (20.7 KB) Mizuki ISHIKAWA, 2020-12-23 08:00

edit_and_delete_after_change.png (27.9 KB) Mizuki ISHIKAWA, 2020-12-23 08:00

diff.patch Magnifier (5.51 KB) Mizuki ISHIKAWA, 2020-12-23 08:01

Related issues

Related to Redmine - Patch #31278: Change Delete button name to Delete Issue New

History

#1 Updated by Mischa The Evil 4 months ago

  • Target version set to Candidate for next minor release
I like this proposal for two reasons even though it comes at the cost of adding three new i18n-strings:
  1. it makes it clearer that these three buttons operate at the custom field scope;
  2. plugins can generically re-use these i18n-strings for their own objects.

#2 Updated by Go MAEDA 4 months ago

  • Related to Patch #31278: Change Delete button name to Delete Issue added

#3 Updated by Go MAEDA 4 months ago

  • Target version changed from Candidate for next minor release to 4.2.0

Setting the target version to 4.2.0.

#4 Updated by Marius BALTEANU 4 months ago

I’m not sure that renaming these 3 buttons is the best solution. Apply & Clear operates at the same level, why are not renamed to Apply custom query and Clear custom query?

From my point of view, a better solution is a UI one which clearly defines the button as part of the custom query section.

Any other feedback in welcome on this topic.

#5 Updated by Mizuki ISHIKAWA 4 months ago

Marius BALTEANU wrote:

I’m not sure that renaming these 3 buttons is the best solution. Apply & Clear operates at the same level, why are not renamed to Apply custom query and Clear custom query?

Clear in Apply is a general term for searching, and I thought it would be easy to understand without adding a subject.
On the other hand, Save, Edit and Delete are hard to understand without the subject.

As far as I know, many people were unaware that custom queries could be saved and reused.
I think it's better to explain in text so that those people can understand the function.

From my point of view, a better solution is a UI one which clearly defines the button as part of the custom query section.

I think it is more effective to have a better UI and linguistic explanation explanation text at the same time.

#6 Updated by Marius BALTEANU 4 months ago

Mizuki ISHIKAWA wrote:

I think it is more effective to have a better UI and linguistic explanation at the same time.

#7 Updated by Marius BALTEANU 4 months ago

Marius BALTEANU wrote:

Mizuki ISHIKAWA wrote:

I think it is more effective to have a better UI and linguistic explanation at the same time.

It's a valid point.

#8 Updated by Marius BALTEANU 3 months ago

  • Target version changed from 4.2.0 to 5.0.0

We need more feedback on this.

Also available in: Atom PDF