Project

General

Profile

Actions
Copy link

Defect #34694

closed

Progress bar for a shared version on gantt disappears when the tree is collapsed and then expanded

Added by Yasu Saku almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Gantt
Target version:
4.1.4
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
4.1.1

Description

Example:

1. Initial state.

2. The bar will disappear when collapsing Version1 directly under Project1.

I suspect that the cause is in the following line.
source:/branches/4.1-stable/public/javascripts/gantt.js@19434#L262

Files

Download all files
initial.png (26.7 KB) initial.png Yasu Saku, 2021-02-07 11:32
collapsed_error.png (21.2 KB) collapsed_error.png Yasu Saku, 2021-02-07 11:36
34694.patch (3.26 KB) 34694.patch Yuichi HARADA, 2021-02-09 08:45
34694-v2.patch (3.28 KB) 34694-v2.patch Yuichi HARADA, 2021-02-15 08:53
Actions
Copy link
 #1

Updated by Go MAEDA almost 4 years ago

  • Status changed from New to Confirmed

I have confirmed the issue. It occurs when a version is shared with subprojects.

Steps to reproduce:

1. Create a shared version in a parent project
2. Set any issue's target version to the shared version in the parent project and its subproject
3. On the gannt, collapse and expand the shared version in the parent project
4. The progress bar for the shared version should appear again after expanding the version but does not

Actions
Copy link
 #2

Updated by Yuichi HARADA almost 4 years ago

Go MAEDA wrote:

I have confirmed the issue. It occurs when a version is shared with subprojects.

Steps to reproduce:

1. Create a shared version in a parent project
2. Set any issue's target version to the shared version in the parent project and its subproject
3. On the gannt, collapse and expand the shared version in the parent project
4. The progress bar for the shared version should appear again after expanding the version but does not

I also confirmed.
When the same shared versions are displayed multiple on Gantt, I can't figure out the target taskbar when collapsing one of these versions. To solve this, the top value at the time of initial display is set in the data-default-top attribute for each display item. This value is used as an attribute of the selector when to execute collapse/expand.
I have attached a patch.

Actions
Copy link
 #3

Updated by Yuichi HARADA almost 4 years ago

Yuichi HARADA wrote:

I also confirmed.
When the same shared versions are displayed multiple on Gantt, I can't figure out the target taskbar when collapsing one of these versions. To solve this, the top value at the time of initial display is set in the data-default-top attribute for each display item. This value is used as an attribute of the selector when to execute collapse/expand.
I have attached a patch.

I could get the number of the current rows, so I remade the patch.

Actions
Copy link
 #4

Updated by Go MAEDA over 3 years ago

  • Target version set to Candidate for next minor release
Actions
Copy link
 #5

Updated by Go MAEDA over 3 years ago

  • Target version changed from Candidate for next minor release to 4.1.4

Setting the target version to 4.1.4.

Actions
Copy link
 #6

Updated by Marius BĂLTEANU over 3 years ago

  • Assignee set to Go MAEDA
Actions
Copy link
 #7

Updated by Go MAEDA over 3 years ago

  • Subject changed from Collapse/expand of Gantt chart does not work properly when multiple bars of the same shared version are displayed. to Progress bar for a shared version on gantt disappears when the tree is collapsed and then expanded
  • Status changed from Confirmed to Closed
  • Resolution set to Fixed

Committed the fix. Thank you.

Actions
Copy link
 #8

Updated by Yasu Saku over 3 years ago

Thank you.

Actions
Copy link

Also available in: Atom PDF