Defect #34856: Time entry error on private issue - Redmine

Actions

Copy link

Defect #34856

closed

Time entry error on private issue

Added by salman mp almost 4 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marius BĂLTEANU

Category:

Time tracking

Target version:

4.1.4

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

4.1.1

Description

When someone edit a private issue that he/she is not auther of that, and simultaiusly changed assignee and submit a time entry, there will raise an error that says "issue number is wrong" and "time entry is wrong" too.

Files

Download all files

time_entry.diff (856 Bytes) time_entry.diff		salman mp, 2021-03-08 16:16
add_test.patch (1.53 KB) add_test.patch		Mizuki ISHIKAWA, 2021-03-18 05:20
0001-Allow-adding-time-entry-on-an-issue-that-became-priv.patch (2.55 KB) 0001-Allow-adding-time-entry-on-an-issue-that-became-priv.patch		Marius BĂLTEANU, 2021-06-09 00:58

Related issues

Actions

Copy link

Updated by salman mp almost 4 years ago

File time_entry.diff time_entry.diff added

It's a patch that solve the problem

Actions

Copy link

Updated by salman mp almost 4 years ago

Also when that user has a role, that only permit to see issues, owned by he/she or assigned to he/she.

Actions

Copy link

Updated by Mizuki ISHIKAWA almost 4 years ago

File add_test.patch add_test.patch added

Add a test to reproduce the problem.
The test will be successful after applying the time_entry.diff patch

Actions

Copy link

Updated by Go MAEDA over 3 years ago

Has duplicate Defect #35038: Error message when limited user want to add time entry and change assignee for a private issue added

Actions

Copy link

Updated by Go MAEDA over 3 years ago

Status changed from New to Confirmed
Target version set to 4.1.3

Setting the target version to 4.1.3

Actions

Copy link

Updated by Marius BĂLTEANU over 3 years ago

Assignee set to Marius BĂLTEANU

I would like to take a look on the fix proposed.

Actions

Copy link

Updated by Marius BĂLTEANU over 3 years ago

Target version changed from 4.1.3 to Candidate for next minor release

Actions

Copy link

Updated by Marius BĂLTEANU over 3 years ago

Target version changed from Candidate for next minor release to 4.1.4

Actions

Copy link

Updated by Marius BĂLTEANU over 3 years ago

File 0001-Allow-adding-time-entry-on-an-issue-that-became-priv.patch 0001-Allow-adding-time-entry-on-an-issue-that-became-priv.patch added

I've updated the proposed patch to fix the test (it failed in my environment) and to fix the Rubocop warnings.

Actions

Copy link

#10

Updated by Marius BĂLTEANU over 3 years ago

Also, I've added an extra condition to allow this only when the previous assignee is the current user (issue.previous_assignee == User.current). Please let me know what do you think.

Actions

Copy link

#11