User link using @ not working at the end of line
|Assignee:||Go MAEDA||% Done:|
Redmine fails to parse mention like @jsmith. (with dot at the end)
At source:trunk/app/helpers/application_helper.rb#L1286 regex extracts full line with all extra sybmols like _-@. and thus can't fide a user with that login.
It only affects separator @, user:jsmith. or user#2. works fine.
Small patch with fix and test in attachment.
Fix user link using @ not working at the end of line (#34894).
Patch by Marius BALTEANU.
#3 Updated by Marius BALTEANU over 1 year ago
- File 0001-Fix-user-mention-using-not-working-at-the-end-of-lin.patch added
- Assignee deleted (
Dmitry, thanks for reporting and fixing this issue, it looks good to me with one mention: we don't need a new test for this case, it's enough to add this case at the existing test.
The patch passes all the tests: https://gitlab.com/redmine-org/redmine/-/pipelines/284519558
#5 Updated by Go MAEDA over 1 year ago
- Subject changed from User mention at the end of line to user link using @ not working at the end of line
- Category set to Text formatting
- Status changed from Confirmed to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the fix. Thank you all for reporting and fixing the issue.