Defect #34894
closed
User link using @ not working at the end of line
0%
Description
Redmine fails to parse mention like @jsmith. (with dot at the end)
At source:trunk/app/helpers/application_helper.rb#L1286 regex extracts full line with all extra sybmols like _-@. and thus can't fide a user with that login.
It only affects separator @, user:jsmith. or Thomas Lecavelier. works fine.
Small patch with fix and test in attachment.
Files
Updated by Marius BĂLTEANU about 4 years ago
- Status changed from New to Confirmed
- Target version set to 4.1.3
- Affected version set to 4.1.0
Updated by Marius BĂLTEANU about 4 years ago
- File 0001-Fix-user-mention-using-not-working-at-the-end-of-lin.patch 0001-Fix-user-mention-using-not-working-at-the-end-of-lin.patch added
- Assignee deleted (
Marius BĂLTEANU)
Dmitry, thanks for reporting and fixing this issue, it looks good to me with one mention: we don't need a new test for this case, it's enough to add this case at the existing test.
The patch passes all the tests: https://gitlab.com/redmine-org/redmine/-/pipelines/284519558
Updated by Dmitry Makurin about 4 years ago
Marius BALTEANU wrote:
we don't need a new test for this case, it's enough to add this case at the existing test.
Just wanted to show the difference between other regexs in same situation. Initially only @ was a problem.
Updated by Go MAEDA about 4 years ago
- Subject changed from User mention at the end of line to user link using @ not working at the end of line
- Category set to Text formatting
- Status changed from Confirmed to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the fix. Thank you all for reporting and fixing the issue.
Updated by Marius BĂLTEANU about 4 years ago
- Subject changed from user link using @ not working at the end of line to User link using @ not working at the end of line