Project

General

Profile

Actions

Defect #34894

closed

User link using @ not working at the end of line

Added by Dmitry Makurin over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Redmine fails to parse mention like @jsmith. (with dot at the end)

At source:trunk/app/helpers/application_helper.rb#L1286 regex extracts full line with all extra sybmols like _-@. and thus can't fide a user with that login.

It only affects separator @, user:jsmith. or Thomas Lecavelier. works fine.

Small patch with fix and test in attachment.


Files

Actions #1

Updated by Marius BĂLTEANU over 3 years ago

  • Assignee set to Marius BĂLTEANU
Actions #2

Updated by Marius BĂLTEANU over 3 years ago

  • Status changed from New to Confirmed
  • Target version set to 4.1.3
  • Affected version set to 4.1.0
Actions #3

Updated by Marius BĂLTEANU over 3 years ago

Dmitry, thanks for reporting and fixing this issue, it looks good to me with one mention: we don't need a new test for this case, it's enough to add this case at the existing test.

The patch passes all the tests: https://gitlab.com/redmine-org/redmine/-/pipelines/284519558

Actions #4

Updated by Dmitry Makurin over 3 years ago

Marius BALTEANU wrote:

we don't need a new test for this case, it's enough to add this case at the existing test.

Just wanted to show the difference between other regexs in same situation. Initially only @ was a problem.

Actions #5

Updated by Go MAEDA over 3 years ago

  • Subject changed from User mention at the end of line to user link using @ not working at the end of line
  • Category set to Text formatting
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you all for reporting and fixing the issue.

Actions #6

Updated by Go MAEDA over 3 years ago

  • Status changed from Resolved to Closed
Actions #7

Updated by Marius BĂLTEANU over 3 years ago

  • Subject changed from user link using @ not working at the end of line to User link using @ not working at the end of line
Actions

Also available in: Atom PDF