Project

General

Profile

Actions

Defect #35192

open

Watchers pop up window appears after a long time

Added by Jean-René ROUET almost 3 years ago. Updated 7 months ago.

Status:
New
Priority:
Normal
Category:
Issues
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

Hi

patch #33329 introduces a performance issue

When you want to add a watcher to an issue in a project with many collaborators, the pop-up window take between 10 sec and 20 sec (according to the number of collaborators) to appear.
It's very disturbing because user has no graphical indication about that.

regards


Related issues

Related to Redmine - Patch #33329: Improve watchers functionality to mark the users that are watching a non visible object and to not return watchers that cannot see the objectClosedGo MAEDA

Actions
Actions #1

Updated by Marius BĂLTEANU almost 3 years ago

  • Assignee set to Marius BĂLTEANU
Actions #2

Updated by Marius BĂLTEANU almost 3 years ago

  • Related to Patch #33329: Improve watchers functionality to mark the users that are watching a non visible object and to not return watchers that cannot see the object added
Actions #3

Updated by Marius BĂLTEANU almost 3 years ago

How many members do you have on the project where you experience this issue? (rounded number).

In #33329, I've proposed two options (4 and 5) to avoid this performance issue, which one works better for you?

Actions #4

Updated by Jean-René ROUET almost 3 years ago

Hi

when it took 10 seconds to pop up, there is 900 members.
when it took 25 seconds, there is 2500 members.
it's linear

I prefer the option 4

Actions #5

Updated by Simon Hori almost 2 years ago

Hello Marius,

Thank you for the patch #33329 that is good improvement for sure.
But we do have the same perfomance problem with 1300+ users.

watchable_object.visible?(user)
is making at least two SQL queries per user.

I don't think we need all users names listed when the search query is blank. so I would like to request option 4.

As a test, I made this change and it reduced loading time from 4 sec to 0.2 sec.

-       scope = @project.principals.assignable_watchers
+       scope = @project.principals.assignable_watchers.limit(100)
Actions #6

Updated by Benoît Yegre over 1 year ago

Hello

We have the same problem that watchers pop up window appears after a long time.

Config :

Environment:
  Redmine version                4.2.8.stable
  Ruby version                   2.7.6-p219 (2022-04-12) [x86_64-linux]
  Rails version                  5.2.8.1
  Environment                    production
  Database adapter               PostgreSQL
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
SCM:
  Subversion                     1.14.1
  Mercurial                      5.6.1
  Bazaar                         3.1.0
  Git                            2.30.2
  Filesystem                     
Redmine plugins:
  redmine_openid_connect         0.9.4

We have 3 000 users and when we want add watchers for an issue, it takes a while to appear the watchers box (20 seconds).

Is there a solution ?
- like limiting watchers for a project ...

Thank you for your help.

Actions #7

Updated by Guillermo ML 7 months ago

We have hit the same performance problems.
We have a project with 1125 members, it takes ~4s to show the windows and another ~3 to see the watcher added.
On projects with few users the action is almost immediate.

Our configuration

Actions

Also available in: Atom PDF